Skip to content

Commit adbc646

Browse files
Fix tests and address review comment
1 parent 6254827 commit adbc646

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

server/src/main/java/org/elasticsearch/action/admin/indices/resolve/TransportResolveClusterAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ protected void doExecuteForked(Task task, ResolveClusterActionRequest request, A
174174
resolveClusterTask.ensureNotCancelled();
175175
String clusterAlias = remoteIndices.getKey();
176176
OriginalIndices originalIndices = remoteIndices.getValue();
177-
boolean skipUnavailable = remoteClusterService.isSkipUnavailable(clusterAlias).orElse(true) == false;
177+
boolean skipUnavailable = remoteClusterService.isSkipUnavailable(clusterAlias).orElse(true);
178178
RemoteClusterClient remoteClusterClient = remoteClusterService.getRemoteClusterClient(
179179
clusterAlias,
180180
searchCoordinationExecutor,

server/src/main/java/org/elasticsearch/transport/RemoteClusterService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public boolean isRemoteClusterServerEnabled() {
161161
private final Map<ProjectId, Map<String, RemoteClusterConnection>> remoteClusters;
162162
private final RemoteClusterCredentialsManager remoteClusterCredentialsManager;
163163
private final ProjectResolver projectResolver;
164-
private final boolean isCpsEnabled;
164+
private final boolean canUseSkipUnavailable;
165165

166166
@FixForMultiProject(description = "Inject the ProjectResolver instance.")
167167
RemoteClusterService(Settings settings, TransportService transportService) {
@@ -183,7 +183,7 @@ public boolean isRemoteClusterServerEnabled() {
183183
* TODO: This is not the right way to check if we're in CPS context and is more of a temporary measure since
184184
* the functionality to do it the right way is not yet ready -- replace this code when it's ready.
185185
*/
186-
this.isCpsEnabled = settings.getAsBoolean("serverless.cross_project.enabled", false);
186+
this.canUseSkipUnavailable = settings.getAsBoolean("serverless.cross_project.enabled", false) == false;
187187
}
188188

189189
/**
@@ -300,7 +300,7 @@ void ensureConnected(String clusterAlias, ActionListener<Void> listener) {
300300
* it returns an empty value where we default/fall back to true.
301301
*/
302302
public Optional<Boolean> isSkipUnavailable(String clusterAlias) {
303-
if (isCpsEnabled) {
303+
if (canUseSkipUnavailable == false) {
304304
return Optional.empty();
305305
} else {
306306
return Optional.of(getRemoteClusterConnection(clusterAlias).isSkipUnavailable());

0 commit comments

Comments
 (0)