Skip to content

Commit ae1ccfd

Browse files
Apply suggestions from code review
Co-authored-by: Carlos Delgado <[email protected]>
1 parent b8d2f68 commit ae1ccfd

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/local/PushExpressionsToFieldLoad.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,9 @@ private Expression transformExpression(Expression e, BlockLoaderExpression ble)
114114
}
115115

116116
private Expression replaceFieldsForFieldTransformations(Expression e, BlockLoaderExpression.PushedBlockLoaderExpression fuse) {
117-
// Change the similarity function to a reference of a transformation on the field
117+
// Change the expression to a reference of the pushed down function on the field
118118
FunctionEsField functionEsField = new FunctionEsField(fuse.field().field(), e.dataType(), fuse.config());
119119
var name = rawTemporaryName(fuse.field().name(), fuse.config().function().toString(), String.valueOf(fuse.config().hashCode()));
120-
// TODO: Check if exists before adding, retrieve the previous one
121120
var newFunctionAttr = new FieldAttribute(
122121
fuse.field().source(),
123122
fuse.field().parentName(),

0 commit comments

Comments
 (0)