Skip to content

Commit ae63901

Browse files
[Island Browser] - Fix Cannot execute ILM policy delete step (#134636)
This PR focuses on the short term solution which add the logs-island_browser.user-* and logs-island_browser.device-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PR. As it ships transform pipeline too hence read, write permissions are also required.
1 parent a017664 commit ae63901

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

docs/changelog/134636.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pr: 134636
2+
summary: "[Island Browser] Add `manage`, `create_index`, `read`, `index`, `write`, `delete`, permission for third party agent indices `kibana_system`"
3+
area: Authorization
4+
type: enhancement
5+
issues:
6+
- 134136

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -549,11 +549,17 @@ static RoleDescriptor kibanaSystem(String name) {
549549
TransportDeleteIndexAction.TYPE.name()
550550
)
551551
.build(),
552-
// For ExtraHop, QualysGAV, and SentinelOne Application Dataset specific actions. Kibana reads, writes and manages this
553-
// index
552+
// For ExtraHop, QualysGAV, SentinelOne Application Dataset and Island Browser specific actions.
553+
// Kibana reads, writes and manages this index
554554
// for configured ILM policies.
555555
RoleDescriptor.IndicesPrivileges.builder()
556-
.indices("logs-extrahop.investigation-*", "logs-qualys_gav.asset-*", "logs-sentinel_one.application-*")
556+
.indices(
557+
"logs-extrahop.investigation-*",
558+
"logs-qualys_gav.asset-*",
559+
"logs-sentinel_one.application-*",
560+
"logs-island_browser.user-*",
561+
"logs-island_browser.device-*"
562+
)
557563
.privileges(
558564
"manage",
559565
"create_index",

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1976,12 +1976,15 @@ public void testKibanaSystemRole() {
19761976
assertThat(kibanaRole.indices().allowedIndicesMatcher(RolloverAction.NAME).test(indexAbstraction), is(true));
19771977
});
19781978

1979-
// Tests for third-party agent indices (ExtraHop, QualysGAV, SentinelOne) that `kibana_system` has full management access to
1979+
// Tests for third-party agent indices (ExtraHop, QualysGAV, SentinelOne, Island Browser) that `kibana_system`
1980+
// has full management access to
19801981
// This includes read, write, create, delete, and all ILM-related management actions.
19811982
Arrays.asList(
19821983
"logs-extrahop.investigation-" + randomAlphaOfLength(randomIntBetween(1, 10)),
19831984
"logs-qualys_gav.asset-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1984-
"logs-sentinel_one.application-" + randomAlphaOfLength(randomIntBetween(1, 10))
1985+
"logs-sentinel_one.application-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1986+
"logs-island_browser.user-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1987+
"logs-island_browser.device-" + randomAlphaOfLength(randomIntBetween(1, 10))
19851988
).forEach((index_qualys_extra_hop) -> {
19861989
final IndexAbstraction indexAbstraction = mockIndexAbstraction(index_qualys_extra_hop);
19871990

0 commit comments

Comments
 (0)