Skip to content

Commit ae9f480

Browse files
committed
Remove old TODO's that are handled, irrelevant now, or will be handled in other PR's currently in flight
1 parent c0b8d7e commit ae9f480

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1595,7 +1595,6 @@ public String[] indices() {
15951595

15961596
@Override
15971597
public IndicesOptions indicesOptions() {
1598-
// PRTODO: What should this allow?
15991598
return IndicesOptions.strictSingleIndexNoExpandForbidClosed();
16001599
}
16011600
});

server/src/main/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,6 @@ public String[] concreteIndexNames(ClusterState state, IndicesOptions options, I
206206
}
207207

208208
public List<String> dataStreamNames(ClusterState state, IndicesOptions options, String... indexExpressions) {
209-
// PRTODO: We should assert that callers of this have selectors disallowed, and direct them to the other method if they do.
210-
// SnapshotService CreateSnapshotRequest
211209
return dataStreams(state, options, indexExpressions).stream().map(ResolvedExpression::resource).distinct().toList();
212210
}
213211

server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -787,8 +787,6 @@ private static Metadata metadataForSnapshot(SnapshotsInProgress.Entry snapshot,
787787
: "Data stream [" + dataStreamName + "] was deleted during a snapshot but snapshot was not partial.";
788788
} else {
789789
boolean missingIndex = false;
790-
// PRTODO: Does this need to be updated? If we take a snapshot of `logs-*::data` and then recover it after deleting the
791-
// stream, will the data stream have a bunch of unreferenced index names in its failure store list?
792790
for (Index index : dataStream.getIndices()) {
793791
final String indexName = index.getName();
794792
if (builder.get(indexName) == null || indicesInSnapshot.contains(indexName) == false) {

0 commit comments

Comments
 (0)