Fixing test and updating code javadoc

Author: jonathan-buttner

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/sender/ChatCompletionInput.java

@@ -7,6 +7,8 @@
 
 package org.elasticsearch.xpack.inference.external.http.sender;
 
+import org.elasticsearch.inference.TaskType;
+
 import java.util.List;
 import java.util.Objects;
 
@@ -15,7 +17,7 @@
  * The main difference between this class and {@link UnifiedChatInput} is this should only be used for
  * {@link org.elasticsearch.inference.TaskType#COMPLETION} originating through the
  * {@link org.elasticsearch.inference.InferenceService#infer} code path. These are requests sent to the
- * API without using the <code>_unified</code> route.
+ * API without using the {@link TaskType#CHAT_COMPLETION} task type.
  */
 public class ChatCompletionInput extends InferenceInputs {
     private final List<String> input;

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/sender/UnifiedChatInput.java

@@ -10,6 +10,7 @@
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.inference.Model;
+import org.elasticsearch.inference.TaskType;
 import org.elasticsearch.inference.UnifiedCompletionRequest;
 
 import java.util.List;
@@ -20,7 +21,7 @@
  * The main difference between this class and {@link ChatCompletionInput} is this should only be used for
  * {@link org.elasticsearch.inference.TaskType#COMPLETION} originating through the
  * {@link org.elasticsearch.inference.InferenceService#unifiedCompletionInfer(Model, UnifiedCompletionRequest, TimeValue, ActionListener)}
- * code path. These are requests sent to the API with the <code>_unified</code> route.
+ * code path. These are requests sent to the API with the <code>_stream</code> route and {@link TaskType#CHAT_COMPLETION}.
  */
 public class UnifiedChatInput extends InferenceInputs {
     private final UnifiedCompletionRequest request;

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/inference/inference_crud.yml

@@ -25,18 +25,3 @@
             }
           }
   - match: { error.reason: "Unknown task_type [bad]" }
-
----
-"Test inference with bad task type":
-  - do:
-      catch: bad_request
-      inference.inference:
-        task_type: bad
-        inference_id: elser_model
-        body: >
-          {
-            "input": "important text"
-          }
-  - match: { error.reason: "Unknown task_type [bad]" }
-
-