Fixed failing test that depends on synonyms feature (#98129)

Author: carlosdelest

docs/build.gradle

@@ -101,6 +101,7 @@ testClusters.matching { it.name == "yamlRestTest"}.configureEach {
 
   requiresFeature 'es.index_mode_feature_flag_registered', Version.fromString("8.0.0")
   requiresFeature 'es.dlm_feature_flag_enabled', Version.fromString("8.8.0")
+  requiresFeature 'es.synonyms_api_feature_flag_enabled', Version.fromString("8.9.0")
 
   // build the cluster with all plugins
   project.rootProject.subprojects.findAll { it.parent.path == ':plugins' }.each { subproj ->
@@ -124,6 +125,7 @@ tasks.named("yamlRestTest").configure {
   }
   if (BuildParams.isSnapshotBuild() == false) {
     systemProperty 'es.dlm_feature_flag_enabled', 'true'
+    systemProperty 'es.synonyms_api_feature_flag_enabled', 'true'
   }
 }
 

docs/reference/migration/apis/feature-migration.asciidoc

@@ -142,7 +142,6 @@ Example response:
   "migration_status" : "NO_MIGRATION_NEEDED"
 }
 --------------------------------------------------
-// TESTRESPONSE[skip:"AwaitsFix https://github.com/elastic/elasticsearch/issues/97780]
 
 When you submit a POST request to the `_migration/system_features` endpoint to
 start the migration process, the response indicates what features will be

server/src/internalClusterTest/java/org/elasticsearch/snapshots/FeatureStateResetApiIT.java

@@ -23,9 +23,11 @@
 import org.elasticsearch.indices.SystemIndexDescriptorUtils;
 import org.elasticsearch.plugins.Plugin;
 import org.elasticsearch.plugins.SystemIndexPlugin;
+import org.elasticsearch.synonyms.SynonymsAPI;
 import org.elasticsearch.test.ESIntegTestCase;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
@@ -48,7 +50,6 @@ protected Collection<Class<? extends Plugin>> nodePlugins() {
     }
 
     /** Check that the reset method cleans up a feature */
-    @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/97780")
     public void testResetSystemIndices() throws Exception {
         String systemIndex1 = ".test-system-idx-1";
         String systemIndex2 = ".second-test-system-idx-1";
@@ -72,16 +73,18 @@ public void testResetSystemIndices() throws Exception {
 
         // call the reset API
         ResetFeatureStateResponse apiResponse = client().execute(ResetFeatureStateAction.INSTANCE, new ResetFeatureStateRequest()).get();
-        assertThat(
-            apiResponse.getFeatureStateResetStatuses(),
-            containsInAnyOrder(
+        Collection<ResetFeatureStateResponse.ResetFeatureStateStatus> successStatuses = new ArrayList<>(
+            Arrays.asList(
                 ResetFeatureStateResponse.ResetFeatureStateStatus.success("SystemIndexTestPlugin"),
                 ResetFeatureStateResponse.ResetFeatureStateStatus.success("SecondSystemIndexTestPlugin"),
                 ResetFeatureStateResponse.ResetFeatureStateStatus.success("EvilSystemIndexTestPlugin"),
-                ResetFeatureStateResponse.ResetFeatureStateStatus.success("tasks"),
-                ResetFeatureStateResponse.ResetFeatureStateStatus.success("synonyms")
+                ResetFeatureStateResponse.ResetFeatureStateStatus.success("tasks")
             )
         );
+        if (SynonymsAPI.isEnabled()) {
+            successStatuses.add(ResetFeatureStateResponse.ResetFeatureStateStatus.success("synonyms"));
+        }
+        assertThat(apiResponse.getFeatureStateResetStatuses(), containsInAnyOrder(successStatuses.toArray()));
 
         // verify that both indices are gone
         Exception e1 = expectThrows(IndexNotFoundException.class, () -> indicesAdmin().prepareGetIndex().addIndices(systemIndex1).get());