Add Query.unscore() to remove scores from a QueryBuilder, use it from tests

Author: carlosdelest

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/querydsl/query/Query.java

@@ -28,6 +28,10 @@
  * </p>
  */
 public abstract class Query {
+
+    // Boosting used to remove scoring from queries that don't contribute to it
+    public static final float NO_SCORE_BOOST = 0.0f;
+
     private final Source source;
 
     protected Query(Source source) {
@@ -51,7 +55,7 @@ public Source source() {
     public final QueryBuilder toQueryBuilder() {
         QueryBuilder builder = asBuilder();
         if (scorable() == false) {
-            builder.boost(0.0f);
+            builder = unscore(builder);
         }
         return builder;
     }
@@ -103,4 +107,11 @@ public Query negate(Source source) {
     public boolean scorable() {
         return false;
     }
+
+    /**
+     * Removes score from a query builder, so score is not affected by the query
+     */
+    public static QueryBuilder unscore(QueryBuilder builder) {
+        return builder.boost(NO_SCORE_BOOST);
+    }
 }