Skip to content

Commit b0daa5a

Browse files
authored
Use static constant for "segments_stats" source (#129406)
So that we more easily know which engine reference it.
1 parent ed7f2ca commit b0daa5a

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

server/src/main/java/org/elasticsearch/index/engine/Engine.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ public abstract class Engine implements Closeable {
132132
public static final String SEARCH_SOURCE = "search"; // TODO: Make source of search enum?
133133
public static final String CAN_MATCH_SEARCH_SOURCE = "can_match";
134134
protected static final String DOC_STATS_SOURCE = "doc_stats";
135+
protected static final String SEGMENTS_STATS_SOURCE = "segments_stats";
135136
public static final long UNKNOWN_PRIMARY_TERM = -1L;
136137
public static final String ROOT_DOC_FIELD_NAME = "__root_doc_for_nested";
137138

@@ -1136,15 +1137,15 @@ public SegmentsStats segmentsStats(boolean includeSegmentFileSizes, boolean incl
11361137
ensureOpen();
11371138
Set<String> segmentName = new HashSet<>();
11381139
SegmentsStats stats = new SegmentsStats();
1139-
try (Searcher searcher = acquireSearcher("segments_stats", SearcherScope.INTERNAL)) {
1140+
try (Searcher searcher = acquireSearcher(SEGMENTS_STATS_SOURCE, SearcherScope.INTERNAL)) {
11401141
for (LeafReaderContext ctx : searcher.getIndexReader().getContext().leaves()) {
11411142
SegmentReader segmentReader = Lucene.segmentReader(ctx.reader());
11421143
fillSegmentStats(segmentReader, includeSegmentFileSizes, stats);
11431144
segmentName.add(segmentReader.getSegmentName());
11441145
}
11451146
}
11461147

1147-
try (Searcher searcher = acquireSearcher("segments_stats", SearcherScope.EXTERNAL)) {
1148+
try (Searcher searcher = acquireSearcher(SEGMENTS_STATS_SOURCE, SearcherScope.EXTERNAL)) {
11481149
for (LeafReaderContext ctx : searcher.getIndexReader().getContext().leaves()) {
11491150
SegmentReader segmentReader = Lucene.segmentReader(ctx.reader());
11501151
if (segmentName.contains(segmentReader.getSegmentName()) == false) {

server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ final boolean assertSearcherIsWarmedUp(String source, SearcherScope scope) {
521521
switch (source) {
522522
// we can access segment_stats while a shard is still in the recovering state.
523523
case "segments":
524-
case "segments_stats":
524+
case SEGMENTS_STATS_SOURCE:
525525
break;
526526
default:
527527
assert externalReaderManager.isWarmedUp : "searcher was not warmed up yet for source[" + source + "]";

x-pack/plugin/core/src/main/java/org/elasticsearch/index/engine/frozen/FrozenEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ private Engine.Searcher openSearcher(String source, SearcherScope scope) throws
250250
case "refresh_needed":
251251
assert false : "refresh_needed is always false";
252252
case "segments":
253-
case "segments_stats":
253+
case SEGMENTS_STATS_SOURCE:
254254
case "completion_stats":
255255
case FIELD_RANGE_SEARCH_SOURCE: // special case for field_range - we use the cached point values reader
256256
case CAN_MATCH_SEARCH_SOURCE: // special case for can_match phase - we use the cached point values reader

0 commit comments

Comments
 (0)