Reduce warnings in entitlement REST tests (#123028) (#123063)

prdoyle · web-flow · commit b14b5a1e57de · 2025-02-21T07:19:32.000+11:00
Backport of a bunch of minor cosmetic changes to reduce warnings.
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/DummyImplementations.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/DummyImplementations.java
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/FileCheckActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/FileCheckActions.java
@@ -40,7 +40,7 @@
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;
 
 @SuppressForbidden(reason = "Explicitly checking APIs that are forbidden")
-@SuppressWarnings("unused") // Called via reflection
+@SuppressWarnings({ "unused" /* called via reflection */, "ResultOfMethodCallIgnored" })
 class FileCheckActions {
 
     static Path testRootDir = Paths.get(System.getProperty("es.entitlements.testdir"));
@@ -62,17 +62,17 @@ static Path readWriteFile() {
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileCanExecute() throws IOException {
+    static void fileCanExecute() {
         readFile().toFile().canExecute();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileCanRead() throws IOException {
+    static void fileCanRead() {
         readFile().toFile().canRead();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileCanWrite() throws IOException {
+    static void fileCanWrite() {
         readFile().toFile().canWrite();
     }
 
@@ -101,68 +101,68 @@ static void fileDeleteOnExit() throws IOException {
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileExists() throws IOException {
+    static void fileExists() {
         readFile().toFile().exists();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileIsDirectory() throws IOException {
+    static void fileIsDirectory() {
         readFile().toFile().isDirectory();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileIsFile() throws IOException {
+    static void fileIsFile() {
         readFile().toFile().isFile();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileIsHidden() throws IOException {
+    static void fileIsHidden() {
         readFile().toFile().isHidden();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileLastModified() throws IOException {
+    static void fileLastModified() {
         readFile().toFile().lastModified();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileLength() throws IOException {
+    static void fileLength() {
         readFile().toFile().length();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileList() throws IOException {
+    static void fileList() {
         readDir().toFile().list();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileListWithFilter() throws IOException {
+    static void fileListWithFilter() {
         readDir().toFile().list((dir, name) -> true);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileListFiles() throws IOException {
+    static void fileListFiles() {
         readDir().toFile().listFiles();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileListFilesWithFileFilter() throws IOException {
+    static void fileListFilesWithFileFilter() {
         readDir().toFile().listFiles(pathname -> true);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileListFilesWithFilenameFilter() throws IOException {
+    static void fileListFilesWithFilenameFilter() {
         readDir().toFile().listFiles((dir, name) -> true);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileMkdir() throws IOException {
+    static void fileMkdir() {
         Path mkdir = readWriteDir().resolve("mkdir");
         mkdir.toFile().mkdir();
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileMkdirs() throws IOException {
+    static void fileMkdirs() {
         Path mkdir = readWriteDir().resolve("mkdirs");
         mkdir.toFile().mkdirs();
     }
@@ -175,27 +175,27 @@ static void fileRenameTo() throws IOException {
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetExecutable() throws IOException {
+    static void fileSetExecutable() {
         readWriteFile().toFile().setExecutable(false);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetExecutableOwner() throws IOException {
+    static void fileSetExecutableOwner() {
         readWriteFile().toFile().setExecutable(false, false);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetLastModified() throws IOException {
+    static void fileSetLastModified() {
         readWriteFile().toFile().setLastModified(System.currentTimeMillis());
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetReadable() throws IOException {
+    static void fileSetReadable() {
         readWriteFile().toFile().setReadable(true);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetReadableOwner() throws IOException {
+    static void fileSetReadableOwner() {
         readWriteFile().toFile().setReadable(true, false);
     }
 
@@ -207,12 +207,12 @@ static void fileSetReadOnly() throws IOException {
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetWritable() throws IOException {
+    static void fileSetWritable() {
         readWriteFile().toFile().setWritable(true);
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
-    static void fileSetWritableOwner() throws IOException {
+    static void fileSetWritableOwner() {
         readWriteFile().toFile().setWritable(true, false);
     }
 
@@ -363,6 +363,7 @@ static void keystoreGetInstance_FileLoadStoreParameter() throws IOException {
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
+    @SuppressWarnings("DataFlowIssue") // Passing null to a @NotNull parameter
     static void keystoreBuilderNewInstance() {
         try {
             KeyStore.Builder.newInstance("", null, readFile().toFile(), null);
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/FileStoreActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/FileStoreActions.java
@@ -16,6 +16,7 @@
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.ALWAYS_DENIED;
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.SERVER_ONLY;
 
+@SuppressWarnings({ "unused" /* called via reflection */ })
 class FileStoreActions {
 
     @EntitlementTest(expectedAccess = ALWAYS_DENIED)
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/ManageThreadsActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/ManageThreadsActions.java
@@ -17,7 +17,7 @@
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;
 
 @SuppressForbidden(reason = "testing entitlements")
-@SuppressWarnings("unused") // used via reflection
+@SuppressWarnings({ "unused" /* called via reflaction */, "removal" })
 class ManageThreadsActions {
     private ManageThreadsActions() {}
 
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NetworkAccessCheckActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NetworkAccessCheckActions.java
@@ -81,7 +81,7 @@ static void urlOpenConnectionWithProxy() throws URISyntaxException, IOException
         assert urlConnection != null;
     }
 
-    static void createLDAPCertStore() throws NoSuchAlgorithmException {
+    static void createLDAPCertStore() {
         try {
             // We pass down null params to provoke a InvalidAlgorithmParameterException
             CertStore.getInstance("LDAP", null);
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NioChannelsActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NioChannelsActions.java
@@ -23,6 +23,7 @@
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.ALWAYS_DENIED;
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;
 
+@SuppressWarnings({ "unused" /* called via reflection */ })
 class NioChannelsActions {
 
     @EntitlementTest(expectedAccess = ALWAYS_DENIED)
@@ -51,7 +52,7 @@ static void fileChannelOpenForReadWithOptions() throws IOException {
     }
 
     @EntitlementTest(expectedAccess = ALWAYS_DENIED)
-    static void createAsynchronousFileChannel() throws IOException {
+    static void createAsynchronousFileChannel() {
         new DummyImplementations.DummyAsynchronousFileChannel().close();
     }
 
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NioFileSystemActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NioFileSystemActions.java
@@ -27,6 +27,7 @@
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.SERVER_ONLY;
 
+@SuppressWarnings({ "unused" /* called via reflection */ })
 class NioFileSystemActions {
 
     @EntitlementTest(expectedAccess = SERVER_ONLY)
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NioFilesActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/NioFilesActions.java
@@ -39,6 +39,7 @@
 import static org.elasticsearch.entitlement.qa.test.FileCheckActions.readWriteDir;
 import static org.elasticsearch.entitlement.qa.test.FileCheckActions.readWriteFile;
 
+@SuppressWarnings({ "unused" /* called via reflection */ })
 class NioFilesActions {
 
     @EntitlementTest(expectedAccess = PLUGINS)
@@ -313,52 +314,36 @@ static void checkFilesIsExecutable() {
 
     @EntitlementTest(expectedAccess = PLUGINS)
     static void checkFilesWalkFileTree() throws IOException {
-        Files.walkFileTree(readDir(), new FileVisitor<>() {
-            @Override
-            public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) throws IOException {
-                return FileVisitResult.SKIP_SUBTREE;
-            }
-
-            @Override
-            public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
-                return FileVisitResult.SKIP_SUBTREE;
-            }
-
-            @Override
-            public FileVisitResult visitFileFailed(Path file, IOException exc) throws IOException {
-                return FileVisitResult.SKIP_SUBTREE;
-            }
-
-            @Override
-            public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException {
-                return FileVisitResult.SKIP_SUBTREE;
-            }
-        });
+        Files.walkFileTree(readDir(), dummyVisitor());
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
     static void checkFilesWalkFileTreeWithOptions() throws IOException {
-        Files.walkFileTree(readDir(), Set.of(FileVisitOption.FOLLOW_LINKS), 2, new FileVisitor<>() {
+        Files.walkFileTree(readDir(), Set.of(FileVisitOption.FOLLOW_LINKS), 2, dummyVisitor());
+    }
+
+    private static FileVisitor<Path> dummyVisitor() {
+        return new FileVisitor<>() {
             @Override
-            public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) throws IOException {
+            public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) {
                 return FileVisitResult.SKIP_SUBTREE;
             }
 
             @Override
-            public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
+            public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
                 return FileVisitResult.SKIP_SUBTREE;
             }
 
             @Override
-            public FileVisitResult visitFileFailed(Path file, IOException exc) throws IOException {
+            public FileVisitResult visitFileFailed(Path file, IOException exc) {
                 return FileVisitResult.SKIP_SUBTREE;
             }
 
             @Override
-            public FileVisitResult postVisitDirectory(Path dir, IOException exc) throws IOException {
+            public FileVisitResult postVisitDirectory(Path dir, IOException exc) {
                 return FileVisitResult.SKIP_SUBTREE;
             }
-        });
+        };
     }
 
     @EntitlementTest(expectedAccess = PLUGINS)
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/PathActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/PathActions.java
@@ -16,6 +16,7 @@
 
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;
 
+@SuppressWarnings({ "unused" /* called via reflection */, "rawtypes" })
 class PathActions {
 
     @EntitlementTest(expectedAccess = PLUGINS)
@@ -28,7 +29,6 @@ static void checkToRealPathNoFollow() throws IOException {
         FileCheckActions.readFile().toRealPath(LinkOption.NOFOLLOW_LINKS);
     }
 
-    @SuppressWarnings("rawtypes")
     @EntitlementTest(expectedAccess = PLUGINS)
     static void checkRegister() throws IOException {
         try (var watchService = FileSystems.getDefault().newWatchService()) {
@@ -38,7 +38,6 @@ static void checkRegister() throws IOException {
         }
     }
 
-    @SuppressWarnings("rawtypes")
     @EntitlementTest(expectedAccess = PLUGINS)
     static void checkRegisterWithModifiers() throws IOException {
         try (var watchService = FileSystems.getDefault().newWatchService()) {
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/SpiActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/SpiActions.java
@@ -15,6 +15,7 @@
 
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.ALWAYS_DENIED;
 
+@SuppressWarnings({ "unused" /* called via reflection */ })
 class SpiActions {
     @EntitlementTest(expectedAccess = ALWAYS_DENIED)
     static void createBreakIteratorProvider() {
@@ -78,14 +79,7 @@ static void createLocaleServiceProvider() {
 
     @EntitlementTest(expectedAccess = ALWAYS_DENIED)
     static void getInheritedChannel() throws IOException {
-        Channel channel = null;
-        try {
-            channel = SelectorProvider.provider().inheritedChannel();
-        } finally {
-            if (channel != null) {
-                channel.close();
-            }
-        }
+        try (Channel channel = SelectorProvider.provider().inheritedChannel()) {}
     }
 
     @EntitlementTest(expectedAccess = ALWAYS_DENIED)
diff --git a/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/SystemActions.java b/libs/entitlement/qa/entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/SystemActions.java
@@ -14,6 +14,7 @@
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.ALWAYS_DENIED;
 import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.SERVER_ONLY;
 
+@SuppressWarnings({ "unused" /* called via reflection */ })
 class SystemActions {
 
     @SuppressForbidden(reason = "Specifically testing Runtime.exit")

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@`
`40`	`40`	`import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;`
`41`	`41`
`42`	`42`	`@SuppressForbidden(reason = "Explicitly checking APIs that are forbidden")`
`43`		`-@SuppressWarnings("unused") // Called via reflection`
	`43`	`+@SuppressWarnings({ "unused" /* called via reflection */, "ResultOfMethodCallIgnored" })`
`44`	`44`	`class FileCheckActions {`
`45`	`45`
`46`	`46`	`static Path testRootDir = Paths.get(System.getProperty("es.entitlements.testdir"));`
`@@ -62,17 +62,17 @@ static Path readWriteFile() {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`@EntitlementTest(expectedAccess = PLUGINS)`
`65`		`- static void fileCanExecute() throws IOException {`
	`65`	`+ static void fileCanExecute() {`
`66`	`66`	`readFile().toFile().canExecute();`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`@EntitlementTest(expectedAccess = PLUGINS)`
`70`		`- static void fileCanRead() throws IOException {`
	`70`	`+ static void fileCanRead() {`
`71`	`71`	`readFile().toFile().canRead();`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`@EntitlementTest(expectedAccess = PLUGINS)`
`75`		`- static void fileCanWrite() throws IOException {`
	`75`	`+ static void fileCanWrite() {`
`76`	`76`	`readFile().toFile().canWrite();`
`77`	`77`	`}`
`78`	`78`
`@@ -101,68 +101,68 @@ static void fileDeleteOnExit() throws IOException {`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`@EntitlementTest(expectedAccess = PLUGINS)`
`104`		`- static void fileExists() throws IOException {`
	`104`	`+ static void fileExists() {`
`105`	`105`	`readFile().toFile().exists();`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`@EntitlementTest(expectedAccess = PLUGINS)`
`109`		`- static void fileIsDirectory() throws IOException {`
	`109`	`+ static void fileIsDirectory() {`
`110`	`110`	`readFile().toFile().isDirectory();`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`@EntitlementTest(expectedAccess = PLUGINS)`
`114`		`- static void fileIsFile() throws IOException {`
	`114`	`+ static void fileIsFile() {`
`115`	`115`	`readFile().toFile().isFile();`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`@EntitlementTest(expectedAccess = PLUGINS)`
`119`		`- static void fileIsHidden() throws IOException {`
	`119`	`+ static void fileIsHidden() {`
`120`	`120`	`readFile().toFile().isHidden();`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`@EntitlementTest(expectedAccess = PLUGINS)`
`124`		`- static void fileLastModified() throws IOException {`
	`124`	`+ static void fileLastModified() {`
`125`	`125`	`readFile().toFile().lastModified();`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`@EntitlementTest(expectedAccess = PLUGINS)`
`129`		`- static void fileLength() throws IOException {`
	`129`	`+ static void fileLength() {`
`130`	`130`	`readFile().toFile().length();`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`@EntitlementTest(expectedAccess = PLUGINS)`
`134`		`- static void fileList() throws IOException {`
	`134`	`+ static void fileList() {`
`135`	`135`	`readDir().toFile().list();`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`@EntitlementTest(expectedAccess = PLUGINS)`
`139`		`- static void fileListWithFilter() throws IOException {`
	`139`	`+ static void fileListWithFilter() {`
`140`	`140`	`readDir().toFile().list((dir, name) -> true);`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`@EntitlementTest(expectedAccess = PLUGINS)`
`144`		`- static void fileListFiles() throws IOException {`
	`144`	`+ static void fileListFiles() {`
`145`	`145`	`readDir().toFile().listFiles();`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`@EntitlementTest(expectedAccess = PLUGINS)`
`149`		`- static void fileListFilesWithFileFilter() throws IOException {`
	`149`	`+ static void fileListFilesWithFileFilter() {`
`150`	`150`	`readDir().toFile().listFiles(pathname -> true);`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`@EntitlementTest(expectedAccess = PLUGINS)`
`154`		`- static void fileListFilesWithFilenameFilter() throws IOException {`
	`154`	`+ static void fileListFilesWithFilenameFilter() {`
`155`	`155`	`readDir().toFile().listFiles((dir, name) -> true);`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`@EntitlementTest(expectedAccess = PLUGINS)`
`159`		`- static void fileMkdir() throws IOException {`
	`159`	`+ static void fileMkdir() {`
`160`	`160`	`Path mkdir = readWriteDir().resolve("mkdir");`
`161`	`161`	`mkdir.toFile().mkdir();`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`@EntitlementTest(expectedAccess = PLUGINS)`
`165`		`- static void fileMkdirs() throws IOException {`
	`165`	`+ static void fileMkdirs() {`
`166`	`166`	`Path mkdir = readWriteDir().resolve("mkdirs");`
`167`	`167`	`mkdir.toFile().mkdirs();`
`168`	`168`	`}`
`@@ -175,27 +175,27 @@ static void fileRenameTo() throws IOException {`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`@EntitlementTest(expectedAccess = PLUGINS)`
`178`		`- static void fileSetExecutable() throws IOException {`
	`178`	`+ static void fileSetExecutable() {`
`179`	`179`	`readWriteFile().toFile().setExecutable(false);`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`@EntitlementTest(expectedAccess = PLUGINS)`
`183`		`- static void fileSetExecutableOwner() throws IOException {`
	`183`	`+ static void fileSetExecutableOwner() {`
`184`	`184`	`readWriteFile().toFile().setExecutable(false, false);`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`@EntitlementTest(expectedAccess = PLUGINS)`
`188`		`- static void fileSetLastModified() throws IOException {`
	`188`	`+ static void fileSetLastModified() {`
`189`	`189`	`readWriteFile().toFile().setLastModified(System.currentTimeMillis());`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`@EntitlementTest(expectedAccess = PLUGINS)`
`193`		`- static void fileSetReadable() throws IOException {`
	`193`	`+ static void fileSetReadable() {`
`194`	`194`	`readWriteFile().toFile().setReadable(true);`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`@EntitlementTest(expectedAccess = PLUGINS)`
`198`		`- static void fileSetReadableOwner() throws IOException {`
	`198`	`+ static void fileSetReadableOwner() {`
`199`	`199`	`readWriteFile().toFile().setReadable(true, false);`
`200`	`200`	`}`
`201`	`201`
`@@ -207,12 +207,12 @@ static void fileSetReadOnly() throws IOException {`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`@EntitlementTest(expectedAccess = PLUGINS)`
`210`		`- static void fileSetWritable() throws IOException {`
	`210`	`+ static void fileSetWritable() {`
`211`	`211`	`readWriteFile().toFile().setWritable(true);`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`@EntitlementTest(expectedAccess = PLUGINS)`
`215`		`- static void fileSetWritableOwner() throws IOException {`
	`215`	`+ static void fileSetWritableOwner() {`
`216`	`216`	`readWriteFile().toFile().setWritable(true, false);`
`217`	`217`	`}`
`218`	`218`
`@@ -363,6 +363,7 @@ static void keystoreGetInstance_FileLoadStoreParameter() throws IOException {`
`363`	`363`	`}`
`364`	`364`
`365`	`365`	`@EntitlementTest(expectedAccess = PLUGINS)`
	`366`	`+ @SuppressWarnings("DataFlowIssue") // Passing null to a @NotNull parameter`
`366`	`367`	`static void keystoreBuilderNewInstance() {`
`367`	`368`	`try {`
`368`	`369`	`KeyStore.Builder.newInstance("", null, readFile().toFile(), null);`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ static void urlOpenConnectionWithProxy() throws URISyntaxException, IOException`
`81`	`81`	`assert urlConnection != null;`
`82`	`82`	`}`
`83`	`83`
`84`		`- static void createLDAPCertStore() throws NoSuchAlgorithmException {`
	`84`	`+ static void createLDAPCertStore() {`
`85`	`85`	`try {`
`86`	`86`	`// We pass down null params to provoke a InvalidAlgorithmParameterException`
`87`	`87`	`CertStore.getInstance("LDAP", null);`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.ALWAYS_DENIED;`
`24`	`24`	`import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;`
`25`	`25`
	`26`	`+@SuppressWarnings({ "unused" /* called via reflection */ })`
`26`	`27`	`class NioChannelsActions {`
`27`	`28`
`28`	`29`	`@EntitlementTest(expectedAccess = ALWAYS_DENIED)`
`@@ -51,7 +52,7 @@ static void fileChannelOpenForReadWithOptions() throws IOException {`
`51`	`52`	`}`
`52`	`53`
`53`	`54`	`@EntitlementTest(expectedAccess = ALWAYS_DENIED)`
`54`		`- static void createAsynchronousFileChannel() throws IOException {`
	`55`	`+ static void createAsynchronousFileChannel() {`
`55`	`56`	`new DummyImplementations.DummyAsynchronousFileChannel().close();`
`56`	`57`	`}`
`57`	`58`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`
`17`	`17`	`import static org.elasticsearch.entitlement.qa.test.EntitlementTest.ExpectedAccess.PLUGINS;`
`18`	`18`
	`19`	`+@SuppressWarnings({ "unused" /* called via reflection */, "rawtypes" })`
`19`	`20`	`class PathActions {`
`20`	`21`
`21`	`22`	`@EntitlementTest(expectedAccess = PLUGINS)`
`@@ -28,7 +29,6 @@ static void checkToRealPathNoFollow() throws IOException {`
`28`	`29`	`FileCheckActions.readFile().toRealPath(LinkOption.NOFOLLOW_LINKS);`
`29`	`30`	`}`
`30`	`31`
`31`		`- @SuppressWarnings("rawtypes")`
`32`	`32`	`@EntitlementTest(expectedAccess = PLUGINS)`
`33`	`33`	`static void checkRegister() throws IOException {`
`34`	`34`	`try (var watchService = FileSystems.getDefault().newWatchService()) {`
`@@ -38,7 +38,6 @@ static void checkRegister() throws IOException {`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
`41`		`- @SuppressWarnings("rawtypes")`
`42`	`41`	`@EntitlementTest(expectedAccess = PLUGINS)`
`43`	`42`	`static void checkRegisterWithModifiers() throws IOException {`
`44`	`43`	`try (var watchService = FileSystems.getDefault().newWatchService()) {`