report all encountered inlinejoins

Author: bpintea

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/capabilities/PostOptimizationPlanVerificationAware.java

@@ -38,7 +38,7 @@ public interface PostOptimizationPlanVerificationAware {
      *      public BiConsumer<LogicalPlan, Failures> postOptimizationPlanVerification() {
      *          return (p, failures) -> {
      *              if (p instanceof InlineJoin inlineJoin) {
-     *                  inlineJoin.left().forEachUp(OrderBy.class, orderBy -> {
+     *                  inlineJoin.forEachUp(OrderBy.class, orderBy -> {
      *                      failures.add(
      *                          fail(
      *                              inlineJoin,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/OrderBy.java

@@ -123,20 +123,19 @@ public void postAnalysisVerification(Failures failures) {
     public BiConsumer<LogicalPlan, Failures> postOptimizationPlanVerification() {
         return (p, failures) -> {
             if (p instanceof InlineJoin inlineJoin) {
-                // walking up the UnaryPlans only, not to warn twice on consecutive INLINESTATS
-                inlineJoin.left().forEachUp(UnaryPlan.class, unary -> {
-                    if (unary instanceof OrderBy orderBy) {
-                        failures.add(
+                inlineJoin.left()
+                    .forEachUp(
+                        OrderBy.class,
+                        orderBy -> failures.add(
                             fail(
                                 inlineJoin,
                                 "inlinestats [{}] cannot yet have an unbounded sort [{}] before it : either move the sort after it,"
                                     + " or add a limit before the sort",
                                 inlineJoin.sourceText(),
                                 orderBy.sourceText()
                             )
-                        );
-                    }
-                });
+                        )
+                    );
             } else if (p instanceof OrderBy) {
                 failures.add(fail(p, "Unbounded sort not supported yet [{}] please add a limit", p.sourceText()));
             }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/OptimizerVerificationTests.java

@@ -30,6 +30,7 @@
 import static org.elasticsearch.xpack.esql.plugin.EsqlPlugin.INLINESTATS_FEATURE_FLAG;
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.instanceOf;
+import static org.hamcrest.Matchers.is;
 
 public class OptimizerVerificationTests extends AbstractLogicalPlanOptimizerTests {
 
@@ -439,13 +440,11 @@ public void testDanglingOrderByInInlineStats() {
             | INLINESTATS s = sum(salary) BY first_name
             """, analyzer);
 
-        assertThat(
-            err,
-            containsString(
-                "2:3: Unbounded sort not supported yet [SORT languages] please add a limit\n"
-                    + "line 3:3: inlinestats [INLINESTATS count(*) BY languages] cannot yet have an unbounded sort [SORT languages] before"
-                    + " it : either move the sort after it, or add a limit before the sort"
-            )
-        );
+        assertThat(err, is("""
+            2:3: Unbounded sort not supported yet [SORT languages] please add a limit
+            line 3:3: inlinestats [INLINESTATS count(*) BY languages] cannot yet have an unbounded sort [SORT languages] before\
+             it : either move the sort after it, or add a limit before the sort
+            line 4:3: inlinestats [INLINESTATS s = sum(salary) BY first_name] cannot yet have an unbounded sort [SORT languages]\
+             before it : either move the sort after it, or add a limit before the sort"""));
     }
 }