Skip to content

Commit b473065

Browse files
Address minor review comments
1 parent 5c9b780 commit b473065

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

server/src/main/java/org/elasticsearch/cluster/metadata/ProjectMetadata.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2059,7 +2059,7 @@ static boolean assertDataStreams(Map<String, IndexMetadata> indices, DataStreamM
20592059
return true;
20602060
}
20612061

2062-
@FixForMultiProject(description = "Remove reading reserved_state and settings")
2062+
@FixForMultiProject(description = "Remove reading reserved_state and settings") // ES-12795
20632063
public static ProjectMetadata fromXContent(XContentParser parser) throws IOException {
20642064
XContentParser.Token token = parser.currentToken();
20652065
if (token == null) {
@@ -2080,7 +2080,7 @@ public static ProjectMetadata fromXContent(XContentParser parser) throws IOExcep
20802080
}
20812081
} else if (token == XContentParser.Token.START_OBJECT) {
20822082
switch (currentFieldName) {
2083-
// Remove this
2083+
// Remove this (ES-12795)
20842084
case "reserved_state" -> {
20852085
while (parser.nextToken() != XContentParser.Token.END_OBJECT) {
20862086
ReservedStateMetadata.fromXContent(parser);
@@ -2096,7 +2096,7 @@ public static ProjectMetadata fromXContent(XContentParser parser) throws IOExcep
20962096
projectBuilder.put(IndexTemplateMetadata.Builder.fromXContent(parser, parser.currentName()));
20972097
}
20982098
}
2099-
// Remove this
2099+
// Remove this (ES-12795)
21002100
case "settings" -> {
21012101
Settings.fromXContent(parser);
21022102
}

server/src/main/java/org/elasticsearch/cluster/project/ProjectStateRegistry.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import java.util.Map;
4141
import java.util.Objects;
4242
import java.util.Set;
43-
import java.util.function.Function;
43+
import java.util.function.UnaryOperator;
4444
import java.util.stream.Collectors;
4545

4646
/**
@@ -316,7 +316,7 @@ private Builder(ProjectStateRegistry original) {
316316
this.projectsMarkedForDeletionGeneration = original.projectsMarkedForDeletionGeneration;
317317
}
318318

319-
private void updateEntry(ProjectId projectId, Function<Entry, Entry> modifier) {
319+
private void updateEntry(ProjectId projectId, UnaryOperator<Entry> modifier) {
320320
Entry entry = projectsEntries.get(projectId);
321321
if (entry == null) {
322322
entry = new Entry();

server/src/main/java/org/elasticsearch/reservedstate/service/FileSettingsService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.elasticsearch.common.io.stream.Writeable;
3333
import org.elasticsearch.common.settings.Setting;
3434
import org.elasticsearch.common.settings.Settings;
35+
import org.elasticsearch.core.FixForMultiProject;
3536
import org.elasticsearch.env.Environment;
3637
import org.elasticsearch.health.HealthIndicatorDetails;
3738
import org.elasticsearch.health.HealthIndicatorImpact;
@@ -131,6 +132,7 @@ public Path watchedFile() {
131132
* @param mdBuilder the current metadata builder for the new cluster state
132133
* @param projectId the project associated with the restore
133134
*/
135+
@FixForMultiProject(description = "Simplify parameters (ES-12796)")
134136
public void handleSnapshotRestore(
135137
ClusterState clusterState,
136138
ClusterState.Builder builder,

0 commit comments

Comments
 (0)