Skip to content

Commit b473dc0

Browse files
thecoopthecoop
committed
Define a new element type rather than a special option
1 parent 522c8ae commit b473dc0

File tree

11 files changed

+230
-123
lines changed

11 files changed

+230
-123
lines changed

‎rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/41_knn_search_bbq_hnsw_bfloat16.yml‎

Lines changed: 12 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ setup:
1313
properties:
1414
vector:
1515
type: dense_vector
16+
element_type: bfloat16
1617
dims: 64
1718
index: true
1819
similarity: max_inner_product
1920
index_options:
2021
type: bbq_hnsw
21-
raw_vector_size: 16
2222

2323
- do:
2424
index:
@@ -191,12 +191,12 @@ setup:
191191
properties:
192192
vector:
193193
type: dense_vector
194+
element_type: bfloat16
194195
dims: 64
195196
element_type: byte
196197
index: true
197198
index_options:
198199
type: bbq_hnsw
199-
raw_vector_size: 16
200200

201201
- do:
202202
catch: bad_request
@@ -207,28 +207,11 @@ setup:
207207
properties:
208208
vector:
209209
type: dense_vector
210+
element_type: bfloat16
210211
dims: 64
211212
index: false
212213
index_options:
213214
type: bbq_hnsw
214-
raw_vector_size: 16
215-
---
216-
"Test bad raw vector size":
217-
- do:
218-
catch: bad_request
219-
indices.create:
220-
index: bad_bbq_hnsw
221-
body:
222-
mappings:
223-
properties:
224-
vector:
225-
type: dense_vector
226-
dims: 64
227-
element_type: byte
228-
index: true
229-
index_options:
230-
type: bbq_hnsw
231-
raw_vector_size: 25
232215
---
233216
"Test few dimensions fail indexing":
234217
- do:
@@ -240,11 +223,11 @@ setup:
240223
properties:
241224
vector:
242225
type: dense_vector
226+
element_type: bfloat16
243227
dims: 42
244228
index: true
245229
index_options:
246230
type: bbq_hnsw
247-
raw_vector_size: 16
248231

249232
- do:
250233
indices.create:
@@ -254,11 +237,11 @@ setup:
254237
properties:
255238
vector:
256239
type: dense_vector
240+
element_type: bfloat16
257241
index: true
258242
similarity: l2_norm
259243
index_options:
260244
type: bbq_hnsw
261-
raw_vector_size: 16
262245

263246
- do:
264247
catch: bad_request
@@ -290,12 +273,12 @@ setup:
290273
properties:
291274
vector:
292275
type: dense_vector
276+
element_type: bfloat16
293277
dims: 64
294278
index: true
295279
similarity: max_inner_product
296280
index_options:
297281
type: bbq_hnsw
298-
raw_vector_size: 16
299282
rescore_vector:
300283
oversample: 1.5
301284

@@ -380,9 +363,9 @@ setup:
380363
properties:
381364
vector:
382365
type: dense_vector
366+
element_type: bfloat16
383367
index_options:
384368
type: bbq_hnsw
385-
raw_vector_size: 16
386369
rescore_vector:
387370
oversample: 0
388371

@@ -397,9 +380,9 @@ setup:
397380
properties:
398381
vector:
399382
type: dense_vector
383+
element_type: bfloat16
400384
index_options:
401385
type: bbq_hnsw
402-
raw_vector_size: 16
403386
rescore_vector:
404387
oversample: 1
405388

@@ -410,9 +393,9 @@ setup:
410393
properties:
411394
vector:
412395
type: dense_vector
396+
element_type: bfloat16
413397
index_options:
414398
type: bbq_hnsw
415-
raw_vector_size: 16
416399
rescore_vector:
417400
oversample: 0
418401

@@ -439,12 +422,12 @@ setup:
439422
properties:
440423
vector:
441424
type: dense_vector
425+
element_type: bfloat16
442426
dims: 64
443427
index: true
444428
similarity: max_inner_product
445429
index_options:
446430
type: bbq_hnsw
447-
raw_vector_size: 16
448431
rescore_vector:
449432
oversample: 0
450433

@@ -520,12 +503,12 @@ setup:
520503
properties:
521504
vector:
522505
type: dense_vector
506+
element_type: bfloat16
523507
dims: 64
524508
index: true
525509
similarity: max_inner_product
526510
index_options:
527511
type: bbq_hnsw
528-
raw_vector_size: 16
529512
rescore_vector:
530513
oversample: 2
531514

@@ -561,12 +544,12 @@ setup:
561544
properties:
562545
vector:
563546
type: dense_vector
547+
element_type: bfloat16
564548
dims: 64
565549
index: true
566550
similarity: max_inner_product
567551
index_options:
568552
type: bbq_hnsw
569-
raw_vector_size: 16
570553
rescore_vector:
571554
oversample: 0
572555

‎rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/42_knn_search_bbq_flat_bfloat16.yml‎

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ setup:
1313
properties:
1414
vector:
1515
type: dense_vector
16+
element_type: bfloat16
1617
dims: 64
1718
index: true
1819
similarity: max_inner_product
1920
index_options:
2021
type: bbq_flat
21-
raw_vector_size: 16
2222

2323
- do:
2424
index:
@@ -187,28 +187,12 @@ setup:
187187
properties:
188188
vector:
189189
type: dense_vector
190+
element_type: bfloat16
190191
dims: 64
191192
index: true
192193
index_options:
193194
type: bbq_flat
194-
raw_vector_size: 16
195195
m: 42
196-
197-
- do:
198-
catch: bad_request
199-
indices.create:
200-
index: bad_bbq_flat
201-
body:
202-
mappings:
203-
properties:
204-
vector:
205-
type: dense_vector
206-
dims: 64
207-
element_type: byte
208-
index: true
209-
index_options:
210-
type: bbq_flat
211-
raw_vector_size: 16
212196
---
213197
"Test bad raw vector size":
214198
- do:
@@ -237,12 +221,12 @@ setup:
237221
properties:
238222
vector:
239223
type: dense_vector
224+
element_type: bfloat16
240225
dims: 42
241226
index: true
242227
similarity: l2_norm
243228
index_options:
244229
type: bbq_flat
245-
raw_vector_size: 16
246230

247231
# verify dynamic dimension fails
248232
- do:
@@ -253,11 +237,11 @@ setup:
253237
properties:
254238
vector:
255239
type: dense_vector
240+
element_type: bfloat16
256241
index: true
257242
similarity: l2_norm
258243
index_options:
259244
type: bbq_flat
260-
raw_vector_size: 16
261245

262246
# verify index fails for odd dim vector
263247
- do:
@@ -291,12 +275,12 @@ setup:
291275
properties:
292276
vector:
293277
type: dense_vector
278+
element_type: bfloat16
294279
dims: 64
295280
index: true
296281
similarity: max_inner_product
297282
index_options:
298283
type: bbq_flat
299-
raw_vector_size: 16
300284
rescore_vector:
301285
oversample: 1.5
302286

@@ -395,12 +379,12 @@ setup:
395379
type: keyword
396380
vector:
397381
type: dense_vector
382+
element_type: bfloat16
398383
dims: 64
399384
index: true
400385
similarity: max_inner_product
401386
index_options:
402387
type: bbq_flat
403-
raw_vector_size: 16
404388

405389
- do:
406390
index:

0 commit comments

Comments
 (0)