Skip to content

Commit b52d3c0

Browse files
authored
ESQL: Remove obsolete comments on filtering (#104359)
1 parent 83565ac commit b52d3c0

File tree

12 files changed

+1
-13
lines changed

12 files changed

+1
-13
lines changed

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/BooleanArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ public boolean getBoolean(int valueIndex) {
6767

6868
@Override
6969
public BooleanBlock filter(int... positions) {
70-
// TODO use reference counting to share the vector
7170
try (var builder = blockFactory().newBooleanBlockBuilder(positions.length)) {
7271
for (int pos : positions) {
7372
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/BooleanBigArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public boolean getBoolean(int valueIndex) {
6868

6969
@Override
7070
public BooleanBlock filter(int... positions) {
71-
// TODO use reference counting to share the vector
7271
try (var builder = blockFactory().newBooleanBlockBuilder(positions.length)) {
7372
for (int pos : positions) {
7473
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/BytesRefArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ public BytesRef getBytesRef(int valueIndex, BytesRef dest) {
7070

7171
@Override
7272
public BytesRefBlock filter(int... positions) {
73-
// TODO use reference counting to share the vector
7473
final BytesRef scratch = new BytesRef();
7574
try (var builder = blockFactory().newBytesRefBlockBuilder(positions.length)) {
7675
for (int pos : positions) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/DoubleArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ public double getDouble(int valueIndex) {
6767

6868
@Override
6969
public DoubleBlock filter(int... positions) {
70-
// TODO use reference counting to share the vector
7170
try (var builder = blockFactory().newDoubleBlockBuilder(positions.length)) {
7271
for (int pos : positions) {
7372
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/DoubleBigArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public double getDouble(int valueIndex) {
6868

6969
@Override
7070
public DoubleBlock filter(int... positions) {
71-
// TODO use reference counting to share the vector
7271
try (var builder = blockFactory().newDoubleBlockBuilder(positions.length)) {
7372
for (int pos : positions) {
7473
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/IntArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ public int getInt(int valueIndex) {
6767

6868
@Override
6969
public IntBlock filter(int... positions) {
70-
// TODO use reference counting to share the vector
7170
try (var builder = blockFactory().newIntBlockBuilder(positions.length)) {
7271
for (int pos : positions) {
7372
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/IntBigArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public int getInt(int valueIndex) {
6868

6969
@Override
7070
public IntBlock filter(int... positions) {
71-
// TODO use reference counting to share the vector
7271
try (var builder = blockFactory().newIntBlockBuilder(positions.length)) {
7372
for (int pos : positions) {
7473
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/LongArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ public long getLong(int valueIndex) {
6767

6868
@Override
6969
public LongBlock filter(int... positions) {
70-
// TODO use reference counting to share the vector
7170
try (var builder = blockFactory().newLongBlockBuilder(positions.length)) {
7271
for (int pos : positions) {
7372
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/LongBigArrayBlock.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public long getLong(int valueIndex) {
6868

6969
@Override
7070
public LongBlock filter(int... positions) {
71-
// TODO use reference counting to share the vector
7271
try (var builder = blockFactory().newLongBlockBuilder(positions.length)) {
7372
for (int pos : positions) {
7473
if (isNull(pos)) {

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/Block.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ public interface Block extends Accountable, BlockLoader.Block, NamedWriteable, R
107107
boolean mayHaveMultivaluedFields();
108108

109109
/**
110-
* Creates a new block that only exposes the positions provided. Materialization of the selected positions is avoided.
111-
* The new block may hold a reference to this block, increasing this block's reference count.
110+
* Creates a new block that only exposes the positions provided.
112111
* @param positions the positions to retain
113112
* @return a filtered block
114113
* TODO: pass BlockFactory

0 commit comments

Comments
 (0)