delete outdated STS regional unit test

Author: DiannaHohensee

modules/repository-s3/qa/web-identity-token/src/test/java/org/elasticsearch/repositories/s3/CustomWebIdentityTokenCredentialsProviderTests.java

@@ -227,34 +227,4 @@ public void testPickUpNewWebIdentityTokenWhenItsChanged() throws Exception {
             httpServer.stop(0);
         }
     }
-
-    public void testSupportRegionalizedEndpoints() throws Exception {
-        Map<String, String> environmentVariables = Map.of(
-            "AWS_WEB_IDENTITY_TOKEN_FILE",
-            "/var/run/secrets/eks.amazonaws.com/serviceaccount/token",
-            "AWS_ROLE_ARN",
-            ROLE_ARN,
-            "AWS_STS_REGIONAL_ENDPOINTS",
-            "regional",
-            "AWS_REGION",
-            "us-west-2"
-        );
-        Map<String, String> systemProperties = Map.of();
-
-        var webIdentityTokenCredentialsProvider = new S3Service.CustomWebIdentityTokenCredentialsProvider(
-            getEnvironment(),
-            environmentVariables::get,
-            systemProperties::getOrDefault,
-            Clock.systemUTC(),
-            resourceWatcherService
-        );
-        // We can't verify that webIdentityTokenCredentialsProvider's STS client uses the "https://sts.us-west-2.amazonaws.com"
-        // endpoint in a unit test. The client depends on hardcoded RegionalEndpointsOptionResolver that in turn depends
-        // on the system environment that we can't change in the test. So we just verify we that we called `withRegion`
-        // on stsClientBuilder which should internally correctly configure the endpoint when the STS client is built.
-        // TODO NOMERGE: can't access region anymore, need to rethink this.
-        // assertEquals("us-west-2", webIdentityTokenCredentialsProvider.getStsRegion());
-
-        webIdentityTokenCredentialsProvider.close();
-    }
 }

modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Service.java

@@ -481,8 +481,6 @@ public CompletableFuture<? extends AwsCredentialsIdentity> resolveIdentity() {
      */
     static class CustomWebIdentityTokenCredentialsProvider implements AwsCredentialsProvider {
 
-        private static final String STS_HOSTNAME = "https://sts.amazonaws.com";
-
         static final String WEB_IDENTITY_TOKEN_FILE_LOCATION = "repository-s3/aws-web-identity-token-file";
 
         private StsWebIdentityTokenFileCredentialsProvider credentialsProvider;
@@ -538,6 +536,8 @@ static class CustomWebIdentityTokenCredentialsProvider implements AwsCredentials
             );
 
             {
+                // TODO NOMERGE: is there any testing we need to add for this? We used to have a unit test that verified the regional stuff,
+                // but we're using this endpoint override instead of region now.
                 final var securityTokenServiceClientBuilder = StsClient.builder();
                 final var endpointOverride = jvmEnvironment.getProperty("org.elasticsearch.repositories.s3.stsEndpointOverride", null);
                 if (endpointOverride != null) {