Skip to content

Commit b70c57b

Browse files
committed
Improve test
1 parent 155b45a commit b70c57b

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/AbstractCrossClusterTestCase.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,21 @@ protected static void assertClusterMetadataInResponse(EsqlQueryResponse resp, bo
146146
} else {
147147
final Object partial = esqlResponseAsMap.get("is_partial");
148148
if (partial != null && (Boolean) partial) {
149-
// If we have partial response, we could have cluster metadata, it should contain details
149+
// If we have partial response, we could have cluster metadata, it should contain details.
150+
// Details should not be empty, and it should contain clusters with failures.
150151
if (clusters != null) {
151152
@SuppressWarnings("unchecked")
152153
Map<String, Object> inner = (Map<String, Object>) clusters;
153154
assertThat(inner, aMapWithSize(1));
154155
assertTrue(inner.containsKey("details"));
156+
@SuppressWarnings("unchecked")
157+
Map<String, Object> details = (Map<String, Object>) inner.get("details");
158+
assertThat(details.size(), greaterThanOrEqualTo(1));
159+
details.forEach((k, v) -> {
160+
@SuppressWarnings("unchecked")
161+
Map<String, Object> cluster = (Map<String, Object>) v;
162+
assertTrue(cluster.containsKey("failures"));
163+
});
155164
}
156165
} else {
157166
assertNull(clusters);

0 commit comments

Comments
 (0)