Merge branch 'empty_bucket' of https://github.com/przemekwitek/elasticsearch into empty_bucket

Author: przemekwitek

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/BlockHash.java

@@ -129,6 +129,7 @@ public record TopNDef(int order, boolean asc, boolean nullsFirst, int limit) {}
 
     public interface EmptyBucketGenerator {
         int getEmptyBucketCount();
+
         Block generate(BlockFactory blockFactory, int maxPositionsInBucket);
     }
 

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Bucket.java

@@ -263,8 +263,13 @@ public boolean foldable() {
     @Override
     public ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
         if (field.dataType() == DataType.DATETIME || field.dataType() == DataType.DATE_NANOS) {
-            Rounding.Prepared preparedRounding =
-                DatetimeEmptyBucketGenerator.determineRounding(field, buckets, from, to, toEvaluator.foldCtx());
+            Rounding.Prepared preparedRounding = DatetimeEmptyBucketGenerator.determineRounding(
+                field,
+                buckets,
+                from,
+                to,
+                toEvaluator.foldCtx()
+            );
             return DateTrunc.evaluator(field.dataType(), source(), toEvaluator.apply(field), preparedRounding);
         }
         if (field.dataType().isNumeric()) {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/DatetimeEmptyBucketGenerator.java

@@ -68,9 +68,7 @@ public int getEmptyBucketCount() {
 
     @Override
     public Block generate(BlockFactory blockFactory, int maxPositionsInBucket) {
-        try (
-            LongBlock.Builder newBlockBuilder = (LongBlock.Builder) ElementType.LONG.newBlockBuilder(maxPositionsInBucket, blockFactory)
-        ) {
+        try (LongBlock.Builder newBlockBuilder = (LongBlock.Builder) ElementType.LONG.newBlockBuilder(maxPositionsInBucket, blockFactory)) {
             int i = 0;
             for (long bucket = rounding.round(from); bucket < to; bucket = rounding.nextRoundingValue(bucket)) {
                 newBlockBuilder.appendLong(bucket);
@@ -85,7 +83,12 @@ public Block generate(BlockFactory blockFactory, int maxPositionsInBucket) {
     }
 
     static Rounding.Prepared determineRounding(
-            Expression field, Expression buckets, Expression from, Expression to, FoldContext foldContext) {
+        Expression field,
+        Expression buckets,
+        Expression from,
+        Expression to,
+        FoldContext foldContext
+    ) {
         assert field.dataType() == DataType.DATETIME || field.dataType() == DataType.DATE_NANOS : "expected date type; got " + field;
         if (buckets.dataType().isWholeNumber()) {
             int b = ((Number) buckets.fold(foldContext)).intValue();

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/NumericEmptyBucketGenerator.java

@@ -40,8 +40,10 @@ public int getEmptyBucketCount() {
     @Override
     public Block generate(BlockFactory blockFactory, int maxPositionsInBucket) {
         try (
-            DoubleBlock.Builder newBlockBuilder =
-                (DoubleBlock.Builder) ElementType.DOUBLE.newBlockBuilder(maxPositionsInBucket, blockFactory)
+            DoubleBlock.Builder newBlockBuilder = (DoubleBlock.Builder) ElementType.DOUBLE.newBlockBuilder(
+                maxPositionsInBucket,
+                blockFactory
+            )
         ) {
             int i = 0;
             for (double bucket = round(Math.floor(from / roundTo) * roundTo, 2); bucket < to; bucket = round(bucket + roundTo, 2)) {