Skip to content

Commit b80ef49

Browse files
committed
Change up some of the CSV tests
1 parent 737eae0 commit b80ef49

File tree

5 files changed

+34
-29
lines changed

5 files changed

+34
-29
lines changed

docs/reference/query-languages/esql/_snippets/functions/examples/network_direction.md

Lines changed: 4 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/kibana/definition/functions/network_direction.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/kibana/docs/functions/network_direction.md

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/qa/testFixtures/src/main/resources/ip.csv-spec

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -733,22 +733,35 @@ ip4:ip | a:ip | b:ip | c:ip
733733
networkDirectionSimple
734734
required_capability: network_direction
735735

736-
// tag::networkDirectionSimple[]
737-
FROM hosts |
738-
WHERE mv_count(ip0) == 1 AND mv_count(ip1) == 1 |
739-
EVAL direction = network_direction(ip0, ip1, ["loopback"]) |
740-
KEEP ip0, ip1, direction
741-
// end::networkDirectionSimple[]
736+
FROM hosts
737+
| WHERE mv_count(ip0) == 1 AND mv_count(ip1) == 1
738+
| EVAL direction = network_direction(ip0, ip1, ["loopback"])
739+
| KEEP ip0, ip1, direction
740+
| SORT direction
742741
;
743742

744-
// tag::networkDirectionSimple-result[]
745743
ip0:ip | ip1:ip | direction:keyword
746-
127.0.0.1 | 127.0.0.1 | internal
747-
::1 | ::1 | internal
744+
fe80::cae2:65ff:fece:feb9 | fe81::cae2:65ff:fece:feb9 | external
745+
fe80::cae2:65ff:fece:feb9 | 127.0.0.3 | inbound
748746
127.0.0.1 | ::1 | internal
749747
127.0.0.1 | 127.0.0.2 | internal
748+
::1 | ::1 | internal
749+
127.0.0.1 | 127.0.0.1 | internal
750750
127.0.0.1 | 128.0.0.1 | outbound
751-
fe80::cae2:65ff:fece:feb9 | fe81::cae2:65ff:fece:feb9 | external
752-
fe80::cae2:65ff:fece:feb9 | 127.0.0.3 | inbound
753-
// end::networkDirectionSimple-result[]
751+
;
752+
753+
networkDirectionFromRow
754+
required_capability: network_direction
755+
756+
// tag::networkDirectionFromRow[]
757+
ROW ip0 = "1.2.3.4"::ip, ip1 = "5.6.7.8"::ip, networks = ["loopback", "private"]
758+
| EVAL direction = network_direction(ip0, ip1, networks)
759+
| DROP networks
760+
// end::networkDirectionFromRow[]
761+
;
762+
763+
// tag::networkDirectionFromRow-result[]
764+
ip0:ip | ip1:ip | direction:keyword
765+
1.2.3.4 | 5.6.7.8 | external
766+
// end::networkDirectionFromRow-result[]
754767
;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public class NetworkDirection extends EsqlScalarFunction {
5858
@FunctionInfo(
5959
returnType = "keyword",
6060
description = "Returns the direction type (inbound, outbound, internal, external) given a source IP address, destination IP address, and a list of internal networks.",
61-
examples = @Example(file = "ip", tag = "networkDirectionSimple")
61+
examples = @Example(file = "ip", tag = "networkDirectionFromRow")
6262
)
6363
public NetworkDirection(
6464
Source source,

0 commit comments

Comments
 (0)