Relax assertion - remove unnecessary times(1) (#118497)

Author: prdoyle

muted-tests.yml

@@ -314,9 +314,6 @@ tests:
   issue: https://github.com/elastic/elasticsearch/issues/118220
 - class: org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT
   issue: https://github.com/elastic/elasticsearch/issues/118238
-- class: org.elasticsearch.reservedstate.service.FileSettingsServiceTests
-  method: testInvalidJSON
-  issue: https://github.com/elastic/elasticsearch/issues/116521
 
 # Examples:
 #

server/src/test/java/org/elasticsearch/reservedstate/service/FileSettingsServiceTests.java

@@ -43,6 +43,7 @@
 import org.elasticsearch.xcontent.XContentParser;
 import org.junit.After;
 import org.junit.Before;
+import org.mockito.Mockito;
 import org.mockito.stubbing.Answer;
 
 import java.io.IOException;
@@ -315,7 +316,13 @@ public void testInvalidJSON() throws Exception {
         writeTestFile(fileSettingsService.watchedFile(), "test_invalid_JSON");
         awaitOrBust(fileChangeBarrier);
 
-        verify(fileSettingsService, times(1)).onProcessFileChangesException(
+        // These checks use atLeast(1) because the initial JSON is also invalid,
+        // and so we sometimes get two calls to these error-reporting methods
+        // depending on timing. Rather than trace down the root cause and fix
+        // it, we tolerate this for now because, hey, invalid JSON is invalid JSON
+        // and this is still testing what we want to test.
+
+        verify(fileSettingsService, Mockito.atLeast(1)).onProcessFileChangesException(
             argThat(e -> unwrapException(e) instanceof XContentParseException)
         );
 
@@ -324,7 +331,7 @@ public void testInvalidJSON() throws Exception {
         // of the watcher thread itself, which occurs asynchronously when clusterChanged is first called.
 
         assertEquals(YELLOW, healthIndicatorService.calculate(false, null).status());
-        verify(healthIndicatorService).failureOccurred(contains(XContentParseException.class.getName()));
+        verify(healthIndicatorService, Mockito.atLeast(1)).failureOccurred(contains(XContentParseException.class.getName()));
     }
 
     /**