Skip to content

Commit bb1d7a1

Browse files
committed
Finish test for cluster-local LOOKUP JOIN
1 parent f7939c0 commit bb1d7a1

File tree

3 files changed

+216
-98
lines changed

3 files changed

+216
-98
lines changed

x-pack/plugin/esql/qa/server/multi-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/AllSupportedFieldsIT.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@
3131
/**
3232
* Fetch all field types via cross cluster search, possible on a different version.
3333
*/
34-
// TODO: ROW + remote ENRICH
35-
// TODO: remote lookups, requires `FROM remote:*`
3634
@ThreadLeakFilters(filters = TestClustersThreadFilter.class)
3735
public class AllSupportedFieldsIT extends AllSupportedFieldsTestCase {
3836
static ElasticsearchCluster remoteCluster = Clusters.remoteCluster();

x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/AllSupportedFieldsIT.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,13 @@
99

1010
import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
1111

12-
import org.elasticsearch.TransportVersion;
13-
import org.elasticsearch.core.Tuple;
1412
import org.elasticsearch.index.IndexMode;
1513
import org.elasticsearch.index.mapper.MappedFieldType;
1614
import org.elasticsearch.test.TestClustersThreadFilter;
1715
import org.elasticsearch.test.cluster.ElasticsearchCluster;
1816
import org.elasticsearch.xpack.esql.qa.rest.AllSupportedFieldsTestCase;
1917
import org.junit.ClassRule;
2018

21-
import java.io.IOException;
22-
import java.util.Map;
23-
2419
/**
2520
* Simple test for fetching all supported field types.
2621
*/
@@ -37,18 +32,4 @@ public AllSupportedFieldsIT(MappedFieldType.FieldExtractPreference extractPrefer
3732
protected String getTestRestCluster() {
3833
return cluster.getHttpAddresses();
3934
}
40-
41-
@Override
42-
@SuppressWarnings("unchecked")
43-
protected void assertMinimumVersionFromAllQueries(Tuple<Map<String, Object>, TransportVersion> responseAndCoordinatorVersion)
44-
throws IOException {
45-
var responseMap = responseAndCoordinatorVersion.v1();
46-
47-
Map<String, Object> profile = (Map<String, Object>) responseMap.get("profile");
48-
Integer minimumVersion = (Integer) profile.get("minimumVersion");
49-
assertNotNull(minimumVersion);
50-
int minVersionInt = minimumVersion;
51-
assertEquals(minVersion().id(), minVersionInt);
52-
assertEquals(TransportVersion.current().id(), minVersionInt);
53-
}
5435
}

0 commit comments

Comments
 (0)