Fix offset types and tests

Author: timgrein

x-pack/plugin/esql/qa/testFixtures/src/main/resources/decay.csv-spec

@@ -5,7 +5,7 @@
 intLinear
 
 ROW value = 5, origin = 10, scale = 10 
-| EVAL decay_result = decay(value, origin, scale, 0.0, 0.5, "linear") 
+| EVAL decay_result = decay(value, origin, scale, 0, 0.5, "linear") 
 | KEEP decay_result;
 
 decay_result:double
@@ -15,7 +15,7 @@ decay_result:double
 intExp
 
 ROW value = 5, origin = 10, scale = 10 
-| EVAL decay_result = decay(value, origin, scale, 0.0, 0.5, "exp") 
+| EVAL decay_result = decay(value, origin, scale, 0, 0.5, "exp") 
 | KEEP decay_result;
 
 decay_result:double
@@ -25,7 +25,7 @@ decay_result:double
 intGauss
 
 ROW value = 5, origin = 10, scale = 10 
-| EVAL decay_result = decay(value, origin, scale, 0.0, 0.5, "gauss") 
+| EVAL decay_result = decay(value, origin, scale, 0, 0.5, "gauss") 
 | KEEP decay_result;
 
 decay_result:double
@@ -35,7 +35,7 @@ decay_result:double
 intLinearWithOffset
 
 ROW value = 95, origin = 100, scale = 50 
-| EVAL decay_result = decay(value, origin, scale, 10.0, 0.3, "linear") 
+| EVAL decay_result = decay(value, origin, scale, 10, 0.3, "linear") 
 | KEEP decay_result;
 
 decay_result:double
@@ -45,7 +45,7 @@ decay_result:double
 intExpWithOffset
 
 ROW value = 120, origin = 100, scale = 50 
-| EVAL decay_result = decay(value, origin, scale, 5.0, 0.3, "exp") 
+| EVAL decay_result = decay(value, origin, scale, 5, 0.3, "exp") 
 | KEEP decay_result;
 
 decay_result:double
@@ -55,7 +55,7 @@ decay_result:double
 intGaussWithOffset
 
 ROW value = 120, origin = 100, scale = 50 
-| EVAL decay_result = decay(value, origin, scale, 5.0, 0.3, "gauss") 
+| EVAL decay_result = decay(value, origin, scale, 5, 0.3, "gauss") 
 | KEEP decay_result;
 
 decay_result:double
@@ -95,7 +95,7 @@ decay_result:double
 longLinear
 
 ROW value = 15::long, origin = 10::long, scale = 10::long
-| EVAL decay_result = decay(value, origin, scale, 0.0, 0.5, "linear") 
+| EVAL decay_result = decay(value, origin, scale, 0::long, 0.5, "linear") 
 | KEEP decay_result;
 
 decay_result:double

x-pack/plugin/esql/src/main/generated/org/elasticsearch/xpack/esql/expression/function/fulltext/DecayIntEvaluator.java

@@ -372,7 +372,7 @@ public EvalOperator.ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvalua
     }
 
     @Evaluator(extraName = "Int")
-    static double process(int value, int origin, int scale, double offset, double decay, BytesRef functionType) {
+    static double process(int value, int origin, int scale, int offset, double decay, BytesRef functionType) {
         return switch (functionType.utf8ToString()) {
             case "exp" -> new ScoreScriptUtils.DecayNumericExp(origin, scale, offset, decay).decayNumericExp(value);
             case "gauss" -> new ScoreScriptUtils.DecayNumericGauss(origin, scale, offset, decay).decayNumericGauss(value);
@@ -390,7 +390,7 @@ static double process(double value, double origin, double scale, double offset,
     }
 
     @Evaluator(extraName = "Long")
-    static double process(long value, long origin, long scale, double offset, double decay, BytesRef functionType) {
+    static double process(long value, long origin, long scale, long offset, double decay, BytesRef functionType) {
         return switch (functionType.utf8ToString()) {
             case "exp" -> new ScoreScriptUtils.DecayNumericExp(origin, scale, offset, decay).decayNumericExp(value);
             case "gauss" -> new ScoreScriptUtils.DecayNumericGauss(origin, scale, offset, decay).decayNumericGauss(value);

x-pack/plugin/esql/src/main/generated/org/elasticsearch/xpack/esql/expression/function/fulltext/DecayLongEvaluator.java

@@ -41,11 +41,9 @@ public static Iterable<Object[]> parameters() {
         List<TestCaseSupplier> testCaseSuppliers = new ArrayList<>();
 
         // Int
-        testCaseSuppliers.addAll(intTestCase(5, 10, 10, 0.0, 0.5, "linear", 0.75));
         testCaseSuppliers.addAll(intTestCase(5, 10, 10, 0, 0.5, "linear", 0.75));
 
         // Long
-        testCaseSuppliers.addAll(longTestCase(5L, 10L, 10L, 0.0, 0.5, "linear", 0.75));
         testCaseSuppliers.addAll(longTestCase(5L, 10L, 10L, 0L, 0.5, "linear", 0.75));
 
         // Double