Fix disk usage estimation for SORTED_SET doc values. (#133722)

martijnvg · web-flow · commit bd7dfa80d235 · 2025-08-28T20:41:23.000+02:00
The `nextOrd()` was never invoked, which can hugely underestimate bytes used for doc sorted set doc values.
diff --git a/docs/changelog/133722.yaml b/docs/changelog/133722.yaml
@@ -0,0 +1,5 @@
+pr: 133722
+summary: Fix disk usage estimation for SORTED_SET doc values
+area: Codec
+type: bug
+issues: []
diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/diskusage/IndexDiskUsageAnalyzer.java b/server/src/main/java/org/elasticsearch/action/admin/indices/diskusage/IndexDiskUsageAnalyzer.java
@@ -277,6 +277,7 @@ void analyzeDocValues(SegmentReader reader, IndexDiskUsageStats stats) throws IO
                     SortedSetDocValues sortedSet = iterateDocValues(maxDocs, () -> docValuesReader.getSortedSet(field), dv -> {
                         for (int i = 0; i < dv.docValueCount(); i++) {
                             cancellationChecker.logEvent();
+                            dv.nextOrd();
                         }
                     });
                     if (sortedSet.getValueCount() > 0) {

Original file line number	Diff line number	Diff line change
`@@ -277,6 +277,7 @@ void analyzeDocValues(SegmentReader reader, IndexDiskUsageStats stats) throws IO`
`277`	`277`	`SortedSetDocValues sortedSet = iterateDocValues(maxDocs, () -> docValuesReader.getSortedSet(field), dv -> {`
`278`	`278`	`for (int i = 0; i < dv.docValueCount(); i++) {`
`279`	`279`	`cancellationChecker.logEvent();`
	`280`	`+ dv.nextOrd();`
`280`	`281`	`}`
`281`	`282`	`});`
`282`	`283`	`if (sortedSet.getValueCount() > 0) {`