Skip to content

Commit be11a06

Browse files
[8.x] ES|QL: make ignoreOrder parsing more strict in CSV tests (#118136) (#118142)
1 parent ffc31fd commit be11a06

File tree

1 file changed

+6
-1
lines changed
  • x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql

1 file changed

+6
-1
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/CsvSpecReader.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,12 @@ public Object parse(String line) {
8080
testCase.expectedWarningsRegexString.add(regex);
8181
testCase.expectedWarningsRegex.add(warningRegexToPattern(regex));
8282
} else if (lower.startsWith("ignoreorder:")) {
83-
testCase.ignoreOrder = Boolean.parseBoolean(line.substring("ignoreOrder:".length()).trim());
83+
String value = lower.substring("ignoreOrder:".length()).trim();
84+
if ("true".equals(value)) {
85+
testCase.ignoreOrder = true;
86+
} else if ("false".equals(value) == false) {
87+
throw new IllegalArgumentException("Invalid value for ignoreOrder: [" + value + "], it can only be true or false");
88+
}
8489
} else if (line.startsWith(";")) {
8590
testCase.expectedResults = data.toString();
8691
// clean-up and emit

0 commit comments

Comments
 (0)