[8.14] Extend the Health API basic YAML tests (#108811) (#109111)

* Extend the Health API basic YAML tests (#108811)

The health node might not have received the health info from all
nodes yet before the execution of this test, resulting in an
"unknown" status. We make the status assertion more lenient to
allow for this uncertainty. Additionally, we add some more
assertions for the basic response structure of the other indicators.

* Merge and bump Health API YAML tests (#109009)

Author: nielsbauman

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/health/10_basic.yml

@@ -1,13 +1,45 @@
 ---
 "cluster health basic test":
   - skip:
-      version: "- 8.6.99"
-      reason: "health was added in 8.2.0, master_is_stable in 8.4.0, and REST API updated in 8.7"
+      version: "- 8.12.99"
+      reason: "data stream lifecycle indicator was added in 8.13.0"
 
   - do:
       health_report: { }
 
   - is_true: cluster_name
-  - match:   { status: "green" }
-  - match:   { indicators.master_is_stable.status: "green" }
-  - match:   { indicators.master_is_stable.symptom: "The cluster has a stable master node" }
+  # This test might execute before the health node has received all health info, resulting in status "unknown"
+  - is_true: status
+  - match: { indicators.master_is_stable.status: "green" }
+  - match: { indicators.master_is_stable.symptom: "The cluster has a stable master node" }
+  - is_true: indicators.master_is_stable.details.current_master.node_id
+  - is_true: indicators.master_is_stable.details.current_master.name
+  - is_true: indicators.master_is_stable.details.recent_masters.0.node_id
+  - is_true: indicators.master_is_stable.details.recent_masters.0.name
+
+  - match: { indicators.repository_integrity.status: "green" }
+  - match: { indicators.repository_integrity.symptom: "No snapshot repositories configured." }
+
+  - is_true: indicators.disk.status
+  - is_true: indicators.disk.symptom
+
+  - match: { indicators.shards_availability.status: "green" }
+  - match: { indicators.shards_availability.symptom: "This cluster has all shards available." }
+  - exists: indicators.shards_availability.details.initializing_replicas
+  - exists: indicators.shards_availability.details.creating_primaries
+  - exists: indicators.shards_availability.details.restarting_replicas
+  - exists: indicators.shards_availability.details.unassigned_primaries
+  - exists: indicators.shards_availability.details.started_replicas
+  - exists: indicators.shards_availability.details.creating_replicas
+  - exists: indicators.shards_availability.details.initializing_primaries
+  - exists: indicators.shards_availability.details.restarting_primaries
+  - exists: indicators.shards_availability.details.started_primaries
+  - exists: indicators.shards_availability.details.unassigned_replicas
+
+  - match: { indicators.shards_capacity.status: "green" }
+  - match: { indicators.shards_capacity.symptom: "The cluster has enough room to add new shards." }
+  - is_true: indicators.shards_capacity.details.data.max_shards_in_cluster
+  - is_true: indicators.shards_capacity.details.frozen.max_shards_in_cluster
+
+  - is_true: indicators.data_stream_lifecycle.status
+  - is_true: indicators.data_stream_lifecycle.symptom

x-pack/plugin/ilm/qa/rest/build.gradle

@@ -8,7 +8,7 @@ dependencies {
 
 restResources {
   restApi {
-    include '_common', 'cluster', 'indices', 'index', 'snapshot', 'ilm', 'slm'
+    include '_common', 'cluster', 'indices', 'index', 'snapshot', 'ilm', 'slm', 'health_report'
   }
 }
 

x-pack/plugin/ilm/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/ilm/80_health.yml

@@ -0,0 +1,17 @@
+---
+"basic ILM health indicator test":
+  - requires:
+      cluster_features: "gte_v8.7.0"
+      reason: "health was added in 8.2.0, master_is_stable in 8.4.0, and REST API updated in 8.7"
+
+  - do:
+      health_report: { }
+
+  - is_true: cluster_name
+  # This test might execute before the health node has received all health info, resulting in status "unknown"
+  - is_true: status
+  - match: { indicators.ilm.status: "green" }
+  - match: { indicators.ilm.symptom: "Index Lifecycle Management is running" }
+  - match: { indicators.ilm.details.ilm_status: "RUNNING" }
+  - is_true: indicators.ilm.details.policies
+  - exists: indicators.ilm.details.stagnating_indices

x-pack/plugin/slm/qa/rest/build.gradle

@@ -8,7 +8,7 @@ dependencies {
 
 restResources {
   restApi {
-    include '_common', 'cluster', 'indices', 'index', 'snapshot', 'slm'
+    include '_common', 'cluster', 'indices', 'index', 'snapshot', 'slm', 'health_report'
   }
 }
 

x-pack/plugin/slm/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/slm/20_health.yml

@@ -0,0 +1,16 @@
+---
+"basic SLM health indicator test":
+  - requires:
+      cluster_features: "gte_v8.7.0"
+      reason: "health was added in 8.2.0, master_is_stable in 8.4.0, and REST API updated in 8.7"
+
+  - do:
+      health_report: { }
+
+  - is_true: cluster_name
+  # This test might execute before the health node has received all health info, resulting in status "unknown"
+  - is_true: status
+  - match: { indicators.slm.status: "green" }
+  - match: { indicators.slm.symptom: "No Snapshot Lifecycle Management policies configured" }
+  - match: { indicators.slm.details.slm_status: "RUNNING" }
+  - exists: indicators.slm.details.policies