Skip to content

Commit bfd8afb

Browse files
committed
Feedback
1 parent d92c15e commit bfd8afb

File tree

3 files changed

+24
-17
lines changed

3 files changed

+24
-17
lines changed

server/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2593,7 +2593,7 @@ private void markRepoCorrupted(long corruptedGeneration, Exception originalExcep
25932593
new ClusterStateUpdateTask() {
25942594
@Override
25952595
public ClusterState execute(ClusterState currentState) {
2596-
final var project = currentState.metadata().getProject();
2596+
final var project = currentState.metadata().getDefaultProject();
25972597
final RepositoriesMetadata state = RepositoriesMetadata.get(project);
25982598
final RepositoryMetadata repoState = state.repository(metadata.name());
25992599
if (repoState.generation() != corruptedGeneration) {
@@ -2787,13 +2787,17 @@ public ClusterState execute(ClusterState currentState) {
27872787
+ "] must be larger than latest known generation ["
27882788
+ latestKnownRepoGen.get()
27892789
+ "]";
2790-
final var project = currentState.metadata().getProject();
2791-
final var updatedRepositoriesMetadata = RepositoriesMetadata.get(project)
2792-
.withUpdatedGeneration(repoName, safeGeneration, newGen);
2793-
return currentState.copyAndUpdateProject(
2794-
project.id(),
2795-
builder -> builder.putCustom(RepositoriesMetadata.TYPE, updatedRepositoriesMetadata)
2796-
);
2790+
final var project = currentState.metadata().getDefaultProject();
2791+
return ClusterState.builder(currentState)
2792+
.putProjectMetadata(
2793+
ProjectMetadata.builder(project)
2794+
.putCustom(
2795+
RepositoriesMetadata.TYPE,
2796+
RepositoriesMetadata.get(project).withUpdatedGeneration(repoName, safeGeneration, newGen)
2797+
)
2798+
.build()
2799+
)
2800+
.build();
27972801
}
27982802

27992803
@Override

x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/AutoFollowCoordinator.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -958,10 +958,11 @@ static Function<ClusterState, ClusterState> cleanFollowedRemoteIndices(
958958
autoFollowPatternNameToFollowedIndexUUIDs,
959959
currentAutoFollowMetadata.getHeaders()
960960
);
961-
return currentState.copyAndUpdateProject(
962-
currentProject.id(),
963-
builder -> builder.putCustom(AutoFollowMetadata.TYPE, newAutoFollowMetadata)
964-
);
961+
return ClusterState.builder(currentState)
962+
.putProjectMetadata(
963+
ProjectMetadata.builder(currentProject).putCustom(AutoFollowMetadata.TYPE, newAutoFollowMetadata).build()
964+
)
965+
.build();
965966
} else {
966967
return currentState;
967968
}

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/persistence/TrainedModelCacheMetadataService.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.elasticsearch.cluster.ClusterStateTaskExecutor;
1818
import org.elasticsearch.cluster.ClusterStateTaskExecutor.TaskContext;
1919
import org.elasticsearch.cluster.ClusterStateTaskListener;
20+
import org.elasticsearch.cluster.metadata.ProjectMetadata;
2021
import org.elasticsearch.cluster.service.ClusterService;
2122
import org.elasticsearch.cluster.service.MasterServiceTaskQueue;
2223
import org.elasticsearch.common.Priority;
@@ -122,11 +123,12 @@ public ClusterState execute(BatchExecutionContext<CacheMetadataUpdateTask> batch
122123
return initialState;
123124
}
124125

125-
final var finalMetadata = currentCacheMetadata;
126-
return initialState.copyAndUpdateProject(
127-
initialState.metadata().getProject().id(),
128-
builder -> builder.putCustom(TrainedModelCacheMetadata.NAME, finalMetadata)
129-
);
126+
return ClusterState.builder(initialState)
127+
.putProjectMetadata(
128+
ProjectMetadata.builder(initialState.metadata().getProject())
129+
.putCustom(TrainedModelCacheMetadata.NAME, currentCacheMetadata)
130+
)
131+
.build();
130132
}
131133
}
132134
}

0 commit comments

Comments
 (0)