Skip to content

Commit c09517b

Browse files
committed
Fix
1 parent 79ebb5e commit c09517b

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

x-pack/plugin/esql/qa/server/multi-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClusterSpecIT.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_PLANNING_V1;
5858
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.METADATA_FIELDS_REMOTE_TEST;
5959
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.UNMAPPED_FIELDS;
60+
import static org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase.hasCapabilities;
6061
import static org.mockito.ArgumentMatchers.any;
6162
import static org.mockito.Mockito.doAnswer;
6263
import static org.mockito.Mockito.mock;
@@ -138,7 +139,10 @@ protected void shouldSkipTest(String testName) throws IOException {
138139
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_PLANNING_V1.capabilityName()));
139140
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V8.capabilityName()));
140141
if (testCase.requiredCapabilities.contains(JOIN_LOOKUP_V12.capabilityName())) {
141-
assumeTrue("LOOKUP JOIN not yet supported in CCS", hasCapabilities(List.of(ENABLE_LOOKUP_JOIN_ON_REMOTE.capabilityName())));
142+
assumeTrue(
143+
"LOOKUP JOIN not yet supported in CCS",
144+
hasCapabilities(client(), List.of(ENABLE_LOOKUP_JOIN_ON_REMOTE.capabilityName()))
145+
);
142146
}
143147
// Unmapped fields require a coorect capability response from every cluster, which isn't currently implemented.
144148
assumeFalse("UNMAPPED FIELDS not yet supported in CCS", testCase.requiredCapabilities.contains(UNMAPPED_FIELDS.capabilityName()));
@@ -387,7 +391,7 @@ protected boolean supportsInferenceTestService() {
387391

388392
@Override
389393
protected boolean supportsIndexModeLookup() throws IOException {
390-
return hasCapabilities(List.of(JOIN_LOOKUP_V12.capabilityName()));
394+
return hasCapabilities(client(), List.of(JOIN_LOOKUP_V12.capabilityName()));
391395
}
392396

393397
@Override

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/RestEsqlTestCase.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,6 +1418,9 @@ private static void prepareProfileLogger(RequestObjectBuilder requestObject, @Nu
14181418
}
14191419
}
14201420

1421+
/**
1422+
* Cache of capabilities.
1423+
*/
14211424
private static final Map<List<String>, Boolean> capabilities = new ConcurrentHashMap<>();
14221425

14231426
public static boolean hasCapabilities(RestClient client, List<String> requiredCapabilities) throws IOException {

0 commit comments

Comments
 (0)