Skip to content

Commit c115b69

Browse files
committed
The parsing tests failure is handled
1 parent 7f4b80a commit c115b69

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

x-pack/plugin/rank-rrf/src/test/java/org/elasticsearch/xpack/rank/linear/LinearRetrieverBuilderParsingTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.util.List;
2828

2929
import static java.util.Collections.emptyList;
30+
import static org.elasticsearch.xpack.rank.linear.LinearRetrieverComponent.DEFAULT_NORMALIZER;
3031

3132
public class LinearRetrieverBuilderParsingTests extends AbstractXContentTestCase<LinearRetrieverBuilder> {
3233
private static List<NamedXContentRegistry.Entry> xContentRegistryEntries;
@@ -51,11 +52,13 @@ protected LinearRetrieverBuilder createTestInstance() {
5152

5253
List<String> fields = null;
5354
String query = null;
54-
ScoreNormalizer normalizer = null;
55+
ScoreNormalizer normalizer;
5556
if (randomBoolean()) {
5657
fields = randomList(1, 10, () -> randomAlphaOfLengthBetween(1, 10));
5758
query = randomAlphaOfLengthBetween(1, 10);
5859
normalizer = randomScoreNormalizer();
60+
} else {
61+
normalizer = DEFAULT_NORMALIZER;
5962
}
6063

6164
int num = randomIntBetween(1, 3);
@@ -67,7 +70,7 @@ protected LinearRetrieverBuilder createTestInstance() {
6770
new CompoundRetrieverBuilder.RetrieverSource(TestRetrieverBuilder.createRandomTestRetrieverBuilder(), null)
6871
);
6972
weights[i] = randomFloat();
70-
normalizers[i] = randomScoreNormalizer();
73+
normalizers[i] = normalizer;
7174
}
7275

7376
return new LinearRetrieverBuilder(innerRetrievers, fields, query, normalizer, rankWindowSize, weights, normalizers);

0 commit comments

Comments
 (0)