iter

Author: john-wagster

server/src/main/java/org/elasticsearch/search/retriever/KnnRetrieverBuilder.java

@@ -286,7 +286,7 @@ public void doToXContent(XContentBuilder builder, Params params) throws IOExcept
         builder.field(K_FIELD.getPreferredName(), k);
         builder.field(NUM_CANDS_FIELD.getPreferredName(), numCands);
 
-        if (visitPercentage != null) {
+        if (IVF_FORMAT.isEnabled() && visitPercentage != null) {
             builder.field(VISIT_PERCENTAGE_FIELD.getPreferredName(), visitPercentage);
         }
 

server/src/test/java/org/elasticsearch/search/vectors/KnnSearchRequestParserTests.java

@@ -308,7 +308,7 @@ private XContentBuilder createRequestBody(KnnSearch knnSearch, List<QueryBuilder
             .field(KnnSearch.FIELD_FIELD.getPreferredName(), knnSearch.field)
             .field(KnnSearch.K_FIELD.getPreferredName(), knnSearch.k)
             .field(KnnSearch.NUM_CANDS_FIELD.getPreferredName(), knnSearch.numCands);
-        if (knnSearch.visitPercentage != null) {
+        if (IVF_FORMAT.isEnabled() && knnSearch.visitPercentage != null) {
             builder.field(KnnSearch.VISIT_PERCENTAGE_FIELD.getPreferredName(), knnSearch.visitPercentage);
         }
         builder.field(KnnSearch.QUERY_VECTOR_FIELD.getPreferredName(), knnSearch.queryVector);

test/framework/src/main/java/org/elasticsearch/test/AbstractQueryVectorBuilderTestCase.java

@@ -33,6 +33,7 @@
 import java.io.IOException;
 import java.util.List;
 
+import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.IVF_FORMAT;
 import static org.elasticsearch.search.SearchService.DEFAULT_SIZE;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.nullValue;
@@ -83,7 +84,7 @@ public final void testKnnSearchBuilderXContent() throws Exception {
                 .queryVectorBuilder(createTestInstance())
                 .k(5)
                 .numCandidates(10)
-                .visitPercentage(10f)
+                .visitPercentage(IVF_FORMAT.isEnabled() ? 10f : null)
                 .similarity(randomBoolean() ? null : randomFloat())
                 .build(DEFAULT_SIZE),
             getToXContentParams(),