Skip to content

Commit c2a7edb

Browse files
committed
ES|QL: Add PRESENT_OVER_TIME ES|QL function
- Comment out TestLogging on CsvTests - Add missing DataTypes to the function Part of #131069
1 parent bb54a7b commit c2a7edb

File tree

5 files changed

+50
-4
lines changed

5 files changed

+50
-4
lines changed

docs/reference/query-languages/esql/_snippets/functions/types/present.md

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/kibana/definition/functions/present.json

Lines changed: 36 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Present.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ public Present(
6464
"double",
6565
"geo_point",
6666
"geo_shape",
67+
"geohash",
68+
"geotile",
69+
"geohex",
6770
"integer",
6871
"ip",
6972
"keyword",

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/CsvTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
* index emits documents a fair random order. Multi-shard and multi-node tests doubly so.</li>
174174
* </ul>
175175
*/
176-
@TestLogging(value = "org.elasticsearch.xpack.esql:TRACE,org.elasticsearch.compute:TRACE", reason = "debug")
176+
// @TestLogging(value = "org.elasticsearch.xpack.esql:TRACE,org.elasticsearch.compute:TRACE", reason = "debug")
177177
public class CsvTests extends ESTestCase {
178178

179179
private static final Logger LOGGER = LogManager.getLogger(CsvTests.class);

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/PresentTests.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.elasticsearch.xpack.esql.core.type.DataType;
1616
import org.elasticsearch.xpack.esql.expression.function.AbstractAggregationTestCase;
1717
import org.elasticsearch.xpack.esql.expression.function.MultiRowTestCaseSupplier;
18+
import org.elasticsearch.xpack.esql.expression.function.MultiRowTestCaseSupplier.IncludingAltitude;
1819
import org.elasticsearch.xpack.esql.expression.function.TestCaseSupplier;
1920

2021
import java.math.BigInteger;
@@ -47,9 +48,12 @@ public static Iterable<Object[]> parameters() {
4748
MultiRowTestCaseSupplier.booleanCases(1, 1000),
4849
MultiRowTestCaseSupplier.ipCases(1, 1000),
4950
MultiRowTestCaseSupplier.versionCases(1, 1000),
50-
MultiRowTestCaseSupplier.geoPointCases(1, 1000, MultiRowTestCaseSupplier.IncludingAltitude.YES),
51-
MultiRowTestCaseSupplier.geoShapeCasesWithoutCircle(1, 1000, MultiRowTestCaseSupplier.IncludingAltitude.YES),
52-
MultiRowTestCaseSupplier.cartesianShapeCasesWithoutCircle(1, 1000, MultiRowTestCaseSupplier.IncludingAltitude.YES),
51+
MultiRowTestCaseSupplier.geoPointCases(1, 1000, IncludingAltitude.YES),
52+
MultiRowTestCaseSupplier.geoShapeCasesWithoutCircle(1, 1000, IncludingAltitude.YES),
53+
MultiRowTestCaseSupplier.cartesianShapeCasesWithoutCircle(1, 1000, IncludingAltitude.YES),
54+
MultiRowTestCaseSupplier.geohashCases(1, 1000),
55+
MultiRowTestCaseSupplier.geotileCases(1, 1000),
56+
MultiRowTestCaseSupplier.geohexCases(1, 1000),
5357
MultiRowTestCaseSupplier.stringCases(1, 1000, DataType.KEYWORD),
5458
MultiRowTestCaseSupplier.stringCases(1, 1000, DataType.TEXT)
5559
).flatMap(List::stream).map(PresentTests::makeSupplier).collect(Collectors.toCollection(() -> suppliers));

0 commit comments

Comments
 (0)