Skip to content

Commit c34d129

Browse files
authored
Add @UpdateForV10 annotation to allow_insecure_settings (#117571)
This hasn't really been necessary since reloadable secure settings landed in 7.0. It's been deprecated for a long time and the last known user has agreed to stop using it in v9. This commit adds a reminder to drop this functionality entirely in v10.
1 parent 094a815 commit c34d129

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

server/src/main/java/org/elasticsearch/common/settings/SecureSetting.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import org.elasticsearch.common.util.ArrayUtils;
1313
import org.elasticsearch.core.Booleans;
14+
import org.elasticsearch.core.UpdateForV10;
1415

1516
import java.io.InputStream;
1617
import java.security.GeneralSecurityException;
@@ -26,6 +27,7 @@
2627
public abstract class SecureSetting<T> extends Setting<T> {
2728

2829
/** Determines whether legacy settings with sensitive values should be allowed. */
30+
@UpdateForV10(owner = UpdateForV10.Owner.DISTRIBUTED_COORDINATION) // this should no longer be in use, even in v9, so can go away in v10
2931
private static final boolean ALLOW_INSECURE_SETTINGS = Booleans.parseBoolean(System.getProperty("es.allow_insecure_settings", "false"));
3032

3133
private static final Set<Property> ALLOWED_PROPERTIES = EnumSet.of(

0 commit comments

Comments
 (0)