Fix tests and typos

Author: Jan-Kazlouski-elastic

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/mistral/completion/MistralChatCompletionServiceSettings.java

@@ -33,7 +33,7 @@
  * This class encapsulates the model ID and rate limit settings for the Mistral chat completion service.
  */
 public class MistralChatCompletionServiceSettings extends FilteredXContentObject implements ServiceSettings {
-    public static final String NAME = "mistral_embeddings_service_settings";
+    public static final String NAME = "mistral_completions_service_settings";
 
     private final String modelId;
     private final RateLimitSettings rateLimitSettings;

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/deepseek/DeepSeekServiceTests.java

@@ -54,6 +54,7 @@
 import static org.elasticsearch.xcontent.ToXContent.EMPTY_PARAMS;
 import static org.elasticsearch.xpack.inference.Utils.inferenceUtilityPool;
 import static org.elasticsearch.xpack.inference.Utils.mockClusterServiceEmpty;
+import static org.elasticsearch.xpack.inference.external.http.Utils.getUrl;
 import static org.elasticsearch.xpack.inference.services.ServiceComponentsTests.createWithEmptySettings;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.Matchers.equalTo;
@@ -276,8 +277,10 @@ public void testUnifiedCompletionError() {
         assertThat(
             e.getMessage(),
             equalTo(
-                "Received an unsuccessful status code for request from inference entity id [inference-id] status"
-                    + " [404]. Error message: [The model `deepseek-not-chat` does not exist or you do not have access to it.]"
+                "Resource not found at ["
+                    + getUrl(webServer)
+                    + "] for request from inference entity id [inference-id]"
+                    + " status [404]. Error message: [The model `deepseek-not-chat` does not exist or you do not have access to it.]"
             )
         );
     }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceServiceTests.java

@@ -66,6 +66,7 @@
 import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
@@ -377,15 +378,14 @@ public void testUnifiedCompletionNonStreamingError() throws Exception {
                             }
                         });
                         var json = XContentHelper.convertToJson(BytesReference.bytes(builder), false, builder.contentType());
-
-                        assertThat(json, is("""
+                        assertThat(json, is(String.format(Locale.ROOT, """
                             {\
                             "error":{\
                             "code":"not_found",\
-                            "message":"Received an unsuccessful status code for request from inference entity id [id] status \
+                            "message":"Resource not found at [%s] for request from inference entity id [id] status \
                             [404]. Error message: [Model not found.]",\
                             "type":"hugging_face_error"\
-                            }}"""));
+                            }}""", getUrl(webServer))));
                     } catch (IOException ex) {
                         throw new RuntimeException(ex);
                     }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/OpenAiResponseHandlerTests.java

@@ -100,7 +100,7 @@ public void testCheckForFailureStatusCode() {
         assertFalse(retryException.shouldRetry());
         assertThat(
             retryException.getCause().getMessage(),
-            containsString("Received an unsuccessful status code for request from inference entity id [id] status [400]")
+            containsString("Received a bad request status code for request from inference entity id [id] status [400]")
         );
         assertThat(((ElasticsearchStatusException) retryException.getCause()).status(), is(RestStatus.BAD_REQUEST));
         // 400 is not flagged as a content too large when the error message is different
@@ -112,7 +112,7 @@ public void testCheckForFailureStatusCode() {
         assertFalse(retryException.shouldRetry());
         assertThat(
             retryException.getCause().getMessage(),
-            containsString("Received an unsuccessful status code for request from inference entity id [id] status [400]")
+            containsString("Received a bad request status code for request from inference entity id [id] status [400]")
         );
         assertThat(((ElasticsearchStatusException) retryException.getCause()).status(), is(RestStatus.BAD_REQUEST));
         // 401

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/OpenAiServiceTests.java

@@ -65,6 +65,7 @@
 import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 
@@ -1153,14 +1154,14 @@ public void testUnifiedCompletionError() throws Exception {
                         });
                         var json = XContentHelper.convertToJson(BytesReference.bytes(builder), false, builder.contentType());
 
-                        assertThat(json, is("""
+                        assertThat(json, is(String.format(Locale.ROOT, """
                             {\
                             "error":{\
                             "code":"model_not_found",\
-                            "message":"Received an unsuccessful status code for request from inference entity id [id] status \
+                            "message":"Resource not found at [%s] for request from inference entity id [id] status \
                             [404]. Error message: [The model `gpt-4awero` does not exist or you do not have access to it.]",\
                             "type":"invalid_request_error"\
-                            }}"""));
+                            }}""", getUrl(webServer))));
                     } catch (IOException ex) {
                         throw new RuntimeException(ex);
                     }