Skip to content

Commit c5a51e9

Browse files
committed
simplify and typo fix
1 parent dae3d72 commit c5a51e9

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

docs/reference/elasticsearch/index-settings/index-modules.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,5 +260,5 @@ $$$index-esql-stored-fields-sequential-proportion$$$
260260
`index.esql.stored_fields_sequential_proportion`
261261
: Tuning parameter for deciding when {{esql}} will load [Stored fields](/reference/elasticsearch/rest-apis/retrieve-selected-fields.md#stored-fields) using a strategy tuned for loading dense sequence of documents. Allows values between 0.0 and 1.0 and defaults to 0.2. Indices with documents smaller than 10kb may see speed improvements loading `text` fields by setting this lower.
262262

263-
$$$index-dense-vector-hnsw-filter-heuristic$$$ `index.dense_vector.hnsw_filter_heuristic`
263+
$$$index-dense-vector-hnsw-early-termination$$$ `index.dense_vector.hnsw_early_termination`
264264
: Whether to apply _patience_ based early termination strategy to knn queries over HNSW graphs (see [paper](https://cs.uwaterloo.ca/~jimmylin/publications/Teofili_Lin_ECIR2025.pdf)). This is only applicable to `dense_vector` fields with `hnsw`, `int8_hnsw`, `int4_hnsw` and `bbq_hnsw` index types. Defaults to `false`.

server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2564,37 +2564,37 @@ private Query createKnnByteQuery(
25642564
private Query maybeWrapPatience(Query knnQuery) {
25652565
Query finalQuery = knnQuery;
25662566
if (knnQuery instanceof KnnByteVectorQuery knnByteVectorQuery) {
2567-
finalQuery = maybeWrapPatienceByte(knnByteVectorQuery, Math.max(7, (int) (knnByteVectorQuery.getK() * 0.3)));
2567+
finalQuery = maybeWrapPatienceByte(knnByteVectorQuery);
25682568
} else if (knnQuery instanceof KnnFloatVectorQuery knnFloatVectorQuery) {
2569-
finalQuery = maybeWrapPatienceFloat(knnFloatVectorQuery, Math.max(7, (int) (knnFloatVectorQuery.getK() * 0.3)));
2569+
finalQuery = maybeWrapPatienceFloat(knnFloatVectorQuery);
25702570
}
25712571
return finalQuery;
25722572
}
25732573

2574-
private Query maybeWrapPatienceByte(KnnByteVectorQuery knnQuery, int patience) {
2574+
private Query maybeWrapPatienceByte(KnnByteVectorQuery knnQuery) {
25752575
Query returnedQuery = knnQuery;
25762576
if (indexOptions instanceof HnswIndexOptions) {
2577-
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery, 0.995, patience);
2577+
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery);
25782578
} else if (indexOptions instanceof Int8HnswIndexOptions) {
2579-
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery, 0.995, patience);
2579+
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery);
25802580
} else if (indexOptions instanceof Int4HnswIndexOptions) {
2581-
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery, 0.995, patience);
2581+
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery);
25822582
} else if (indexOptions instanceof BBQHnswIndexOptions) {
2583-
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery, 0.995, patience);
2583+
returnedQuery = PatienceKnnVectorQuery.fromByteQuery(knnQuery);
25842584
}
25852585
return returnedQuery;
25862586
}
25872587

2588-
private Query maybeWrapPatienceFloat(KnnFloatVectorQuery knnQuery, int patience) {
2588+
private Query maybeWrapPatienceFloat(KnnFloatVectorQuery knnQuery) {
25892589
Query returnedQuery = knnQuery;
2590-
if (indexOptions instanceof HnswIndexOptions hnswIndexOptions) {
2591-
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery, 0.995, patience);
2592-
} else if (indexOptions instanceof Int8HnswIndexOptions hnswIndexOptions) {
2593-
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery, 0.995, patience);
2594-
} else if (indexOptions instanceof Int4HnswIndexOptions hnswIndexOptions) {
2595-
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery, 0.995, patience);
2596-
} else if (indexOptions instanceof BBQHnswIndexOptions hnswIndexOptions) {
2597-
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery, 0.995, patience);
2590+
if (indexOptions instanceof HnswIndexOptions) {
2591+
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery);
2592+
} else if (indexOptions instanceof Int8HnswIndexOptions) {
2593+
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery);
2594+
} else if (indexOptions instanceof Int4HnswIndexOptions) {
2595+
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery);
2596+
} else if (indexOptions instanceof BBQHnswIndexOptions) {
2597+
returnedQuery = PatienceKnnVectorQuery.fromFloatQuery(knnQuery);
25982598
}
25992599
return returnedQuery;
26002600
}

0 commit comments

Comments
 (0)