Fix error message

Author: luigidellaquila

x-pack/plugin/build.gradle

@@ -134,7 +134,6 @@ tasks.named("yamlRestCompatTestTransform").configure({ task ->
   task.skipTest("esql/90_non_indexed/fetch", "Temporary until backported")
   task.skipTest("esql/63_enrich_int_range/Invalid age as double", "TODO: require disable allow_partial_results")
   task.skipTest("esql/191_lookup_join_on_datastreams/data streams not supported in LOOKUP JOIN", "Added support for aliases in JOINs")
-  task.skipTest("esql/10_basic/Test wrong LIMIT parameter", "Different error message")
   task.skipTest("esql/190_lookup_join/non-lookup index", "Error message changed")
   task.skipTest("esql/192_lookup_join_on_aliases/alias-pattern-multiple", "Error message changed")
 })

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java

@@ -396,7 +396,7 @@ public PlanFactory visitLimitCommand(EsqlBaseParser.LimitCommandContext ctx) {
                 "Invalid value for LIMIT ["
                     + BytesRefs.toString(val)
                     + ": "
-                    + expression(ctx.constant()).dataType()
+                    + (expression(ctx.constant()).dataType() == KEYWORD ? "String" : val.getClass().getSimpleName())
                     + "], expecting a non negative integer"
             );
         }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/ParsingTests.java

@@ -157,7 +157,7 @@ public void testJoinTwiceOnTheSameField_TwoLookups() {
     }
 
     public void testInvalidLimit() {
-        assertEquals("1:13: Invalid value for LIMIT [foo: KEYWORD], expecting a non negative integer", error("row a = 1 | limit \"foo\""));
+        assertEquals("1:13: Invalid value for LIMIT [foo: String], expecting a non negative integer", error("row a = 1 | limit \"foo\""));
         assertEquals("1:13: Invalid value for LIMIT [1.2: DOUBLE], expecting a non negative integer", error("row a = 1 | limit 1.2"));
         assertEquals("1:13: Invalid value for LIMIT [-1], expecting a non negative integer", error("row a = 1 | limit -1"));
     }

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/10_basic.yml

@@ -553,7 +553,7 @@ FROM EVAL SORT LIMIT with documents_found:
       reason: "named or positional parameters for field names"
 
   - do:
-      catch: "/Invalid value for LIMIT \\[foo: KEYWORD\\], expecting a non negative integer/"
+      catch: "/Invalid value for LIMIT \\[foo: String\\], expecting a non negative integer/"
       esql.query:
         body:
           query: 'from test | limit ?l'