Skip to content

Commit c803bdb

Browse files
authored
Removed seqno_field_use_tsdb_doc_values_format feature flag (#135374)
1 parent 87a108f commit c803bdb

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

server/src/main/java/org/elasticsearch/index/codec/PerFieldFormatSupplier.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import org.apache.lucene.codecs.lucene90.Lucene90DocValuesFormat;
1616
import org.apache.lucene.codecs.lucene99.Lucene99HnswVectorsFormat;
1717
import org.elasticsearch.common.util.BigArrays;
18-
import org.elasticsearch.common.util.FeatureFlag;
1918
import org.elasticsearch.index.IndexMode;
2019
import org.elasticsearch.index.IndexSettings;
2120
import org.elasticsearch.index.IndexVersions;
@@ -41,7 +40,6 @@
4140
*/
4241
public class PerFieldFormatSupplier {
4342

44-
static final FeatureFlag SEQNO_FIELD_USE_TSDB_DOC_VALUES_FORMAT = new FeatureFlag("seqno_field_use_tsdb_doc_values_format");
4543
private static final Set<String> INCLUDE_META_FIELDS;
4644

4745
static {
@@ -51,9 +49,7 @@ public class PerFieldFormatSupplier {
5149
Set<String> includeMetaField = new HashSet<>(3);
5250
includeMetaField.add(TimeSeriesIdFieldMapper.NAME);
5351
includeMetaField.add(TimeSeriesRoutingHashFieldMapper.NAME);
54-
if (SEQNO_FIELD_USE_TSDB_DOC_VALUES_FORMAT.isEnabled()) {
55-
includeMetaField.add(SeqNoFieldMapper.NAME);
56-
}
52+
includeMetaField.add(SeqNoFieldMapper.NAME);
5753
// Don't the include _recovery_source_size and _recovery_source fields, since their values can be trimmed away in
5854
// RecoverySourcePruneMergePolicy, which leads to inconsistencies between merge stats and actual values.
5955
INCLUDE_META_FIELDS = Collections.unmodifiableSet(includeMetaField);

server/src/test/java/org/elasticsearch/index/codec/PerFieldMapperCodecTests.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -215,23 +215,10 @@ public void testMetaFields() throws IOException {
215215
}
216216

217217
public void testSeqnoField() throws IOException {
218-
assumeTrue(
219-
"seqno_field_use_tsdb_doc_values_format should be enabled",
220-
PerFieldFormatSupplier.SEQNO_FIELD_USE_TSDB_DOC_VALUES_FORMAT.isEnabled()
221-
);
222218
PerFieldFormatSupplier perFieldMapperCodec = createFormatSupplier(true, IndexMode.LOGSDB, MAPPING_3);
223219
assertThat((perFieldMapperCodec.useTSDBDocValuesFormat(SeqNoFieldMapper.NAME)), is(true));
224220
}
225221

226-
public void testSeqnoFieldFeatureFlagDisabled() throws IOException {
227-
assumeTrue(
228-
"seqno_field_use_tsdb_doc_values_format should be disabled",
229-
PerFieldFormatSupplier.SEQNO_FIELD_USE_TSDB_DOC_VALUES_FORMAT.isEnabled() == false
230-
);
231-
PerFieldFormatSupplier perFieldMapperCodec = createFormatSupplier(true, IndexMode.LOGSDB, MAPPING_3);
232-
assertThat((perFieldMapperCodec.useTSDBDocValuesFormat(SeqNoFieldMapper.NAME)), is(false));
233-
}
234-
235222
private PerFieldFormatSupplier createFormatSupplier(boolean enableES87TSDBCodec, IndexMode mode, String mapping) throws IOException {
236223
Settings.Builder settings = Settings.builder();
237224
settings.put(IndexSettings.MODE.getKey(), mode);

0 commit comments

Comments
 (0)