Skip to content

Commit c82d719

Browse files
committed
migrated CentroidAssignments to a class to hide default constructor, minor change from long to int
1 parent b6d61fa commit c82d719

File tree

2 files changed

+31
-2
lines changed

2 files changed

+31
-2
lines changed

server/src/main/java/org/elasticsearch/index/codec/vectors/CentroidAssignments.java

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,19 @@
99

1010
package org.elasticsearch.index.codec.vectors;
1111

12-
record CentroidAssignments(int numCentroids, float[][] cachedCentroids, int[] assignments, int[] soarAssignments) {
12+
final class CentroidAssignments {
13+
14+
private final int numCentroids;
15+
private final float[][] cachedCentroids;
16+
private final int[] assignments;
17+
private final int[] soarAssignments;
18+
19+
private CentroidAssignments(int numCentroids, float[][] cachedCentroids, int[] assignments, int[] soarAssignments) {
20+
this.numCentroids = numCentroids;
21+
this.cachedCentroids = cachedCentroids;
22+
this.assignments = assignments;
23+
this.soarAssignments = soarAssignments;
24+
}
1325

1426
CentroidAssignments(float[][] centroids, int[] assignments, int[] soarAssignments) {
1527
this(centroids.length, centroids, assignments, soarAssignments);
@@ -18,4 +30,21 @@ record CentroidAssignments(int numCentroids, float[][] cachedCentroids, int[] as
1830
CentroidAssignments(int numCentroids, int[] assignments, int[] soarAssignments) {
1931
this(numCentroids, null, assignments, soarAssignments);
2032
}
33+
34+
// Getters and setters
35+
public int numCentroids() {
36+
return numCentroids;
37+
}
38+
39+
public float[][] cachedCentroids() {
40+
return cachedCentroids;
41+
}
42+
43+
public int[] assignments() {
44+
return assignments;
45+
}
46+
47+
public int[] soarAssignments() {
48+
return soarAssignments;
49+
}
2150
}

server/src/main/java/org/elasticsearch/index/codec/vectors/cluster/KMeans.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ private boolean stepLloyd(FloatVectorValues vectors, float[][] centroids, int[]
5757
throws IOException {
5858
boolean changed = false;
5959
int dim = vectors.dimension();
60-
long[] centroidCounts = new long[centroids.length];
60+
int[] centroidCounts = new int[centroids.length];
6161
float[][] nextCentroids = new float[centroids.length][dim];
6262

6363
for (int i = 0; i < sampleSize; i++) {

0 commit comments

Comments
 (0)