Skip to content

Commit c87614c

Browse files
authored
ESQL: Add skips to tests that were added retroactively (#114727) (#114792)
Skip some csv tests that cannot be used in bwc tests before 8.13/8.14.
1 parent 581894a commit c87614c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/date.csv-spec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ date1:date | dd_ms:integer
367367
2023-12-02T11:00:00.000Z | 1000
368368
;
369369

370-
evalDateDiffMonthAsWhole0Months
370+
evalDateDiffMonthAsWhole0Months#[skip:-8.14.1, reason:omitting millis/timezone not allowed before 8.14]
371371

372372
ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-01-01T00:00:00")
373373
| EVAL msecs=DATE_DIFF("milliseconds", from, to), months=DATE_DIFF("month", from, to)
@@ -378,7 +378,7 @@ ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-01-01T00:
378378

379379
;
380380

381-
evalDateDiffMonthAsWhole1Month
381+
evalDateDiffMonthAsWhole1Month#[skip:-8.14.1, reason:omitting millis/timezone not allowed before 8.14]
382382

383383
ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-02-01T00:00:00")
384384
| EVAL secs=DATE_DIFF("seconds", from, to), months=DATE_DIFF("month", from, to)

x-pack/plugin/esql/qa/testFixtures/src/main/resources/topN.csv-spec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ null |Swan |-8.46 |-8.46
135135
Sanjiv |Zschoche |[-7.67, -3.25] |[-3.25, -7.67] |[-3, -8] |10053
136136
;
137137

138-
sortingOnSwappedFields
138+
sortingOnSwappedFields#[skip:-8.13.3, reason:fixed in 8.13]
139139
FROM employees
140140
| EVAL name = last_name, last_name = first_name, first_name = name
141141
| WHERE first_name > "B" AND last_name IS NOT NULL
@@ -157,7 +157,7 @@ Brattka | Charlene | Brattka
157157
Bridgland | Patricio | Bridgland
158158
;
159159

160-
sortingOnSwappedFieldsNoKeep
160+
sortingOnSwappedFieldsNoKeep#[skip:-8.13.3, reason:fixed in 8.13]
161161
// Note that this test requires all fields to be returned in order to test a specific code path in physical planning
162162
FROM employees
163163
| EVAL name = first_name, first_name = last_name, last_name = name

0 commit comments

Comments
 (0)