Fix NodeJoinExecutorTests#testSuccess (#119064)

javanna · web-flow · commit c8d2c7d851d1 · 2024-12-19T14:23:13.000+01:00
This is related to #119013, we can lower the minimum compatible version to read only compatible version to make the test succeed at all times. Closes #119052
diff --git a/muted-tests.yml b/muted-tests.yml
@@ -298,9 +298,6 @@ tests:
   issue: https://github.com/elastic/elasticsearch/issues/116777
 - class: org.elasticsearch.xpack.security.authc.ldap.ActiveDirectoryRunAsIT
   issue: https://github.com/elastic/elasticsearch/issues/115727
-- class: org.elasticsearch.cluster.coordination.NodeJoinExecutorTests
-  method: testSuccess
-  issue: https://github.com/elastic/elasticsearch/issues/119052
 
 # Examples:
 #
diff --git a/server/src/test/java/org/elasticsearch/cluster/coordination/NodeJoinExecutorTests.java b/server/src/test/java/org/elasticsearch/cluster/coordination/NodeJoinExecutorTests.java
@@ -467,7 +467,7 @@ public void testSuccess() {
             .build();
         metaBuilder.put(indexMetadata, false);
         Metadata metadata = metaBuilder.build();
-        NodeJoinExecutor.ensureIndexCompatibility(IndexVersions.MINIMUM_COMPATIBLE, IndexVersion.current(), metadata);
+        NodeJoinExecutor.ensureIndexCompatibility(IndexVersions.MINIMUM_READONLY_COMPATIBLE, IndexVersion.current(), metadata);
     }
 
     public static Settings.Builder randomCompatibleVersionSettings() {

Original file line number	Diff line number	Diff line change
`@@ -298,9 +298,6 @@ tests:`
`298`	`298`	`issue: https://github.com/elastic/elasticsearch/issues/116777`
`299`	`299`	`- class: org.elasticsearch.xpack.security.authc.ldap.ActiveDirectoryRunAsIT`
`300`	`300`	`issue: https://github.com/elastic/elasticsearch/issues/115727`
`301`		`-- class: org.elasticsearch.cluster.coordination.NodeJoinExecutorTests`
`302`		`- method: testSuccess`
`303`		`- issue: https://github.com/elastic/elasticsearch/issues/119052`
`304`	`301`
`305`	`302`	`# Examples:`
`306`	`303`	`#`
Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ public void testSuccess() {`
`467`	`467`	`.build();`
`468`	`468`	`metaBuilder.put(indexMetadata, false);`
`469`	`469`	`Metadata metadata = metaBuilder.build();`
`470`		`- NodeJoinExecutor.ensureIndexCompatibility(IndexVersions.MINIMUM_COMPATIBLE, IndexVersion.current(), metadata);`
	`470`	`+ NodeJoinExecutor.ensureIndexCompatibility(IndexVersions.MINIMUM_READONLY_COMPATIBLE, IndexVersion.current(), metadata);`
`471`	`471`	`}`
`472`	`472`
`473`	`473`	`public static Settings.Builder randomCompatibleVersionSettings() {`