Skip to content

Commit ca6bb44

Browse files
committed
SQL: Comment that we're not removing deprecated
This adds a comment that we're not removing `index_include_frozen` to make sure we don't break anyone.
1 parent 8d4f034 commit ca6bb44

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

x-pack/plugin/sql/sql-action/src/main/java/org/elasticsearch/xpack/sql/action/SqlQueryRequest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ public class SqlQueryRequest extends AbstractSqlQueryRequest {
7070
PARSER.declareBoolean(SqlQueryRequest::columnar, COLUMNAR);
7171
PARSER.declareBoolean(SqlQueryRequest::fieldMultiValueLeniency, FIELD_MULTI_VALUE_LENIENCY);
7272
PARSER.declareBoolean((r, v) -> {
73+
/*
74+
* We don't plan to remove this no matter how few folks use it to make sure
75+
* we don't break anyone.
76+
*/
7377
DEPRECATION_LOGGER.warn(DeprecationCategory.API, "sql_index_include_frozen", INDEX_INCLUDE_FROZEN_DEPRECATION_MESSAGE);
7478
r.indexIncludeFrozen(v);
7579
}, INDEX_INCLUDE_FROZEN);

x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/parser/LogicalPlanBuilder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ abstract class LogicalPlanBuilder extends ExpressionBuilder {
7878

7979
protected void maybeWarnDeprecatedFrozenSyntax(boolean includeFrozen, String syntax) {
8080
if (includeFrozen) {
81+
/*
82+
* We don't plan to remove this no matter how few folks use it to make sure
83+
* we don't break anyone.
84+
*/
8185
DEPRECATION_LOGGER.warn(DeprecationCategory.PARSING, "include_frozen_syntax", format(null, FROZEN_DEPRECATION_WARNING, syntax));
8286
}
8387
}

0 commit comments

Comments
 (0)