no need for volatile read

Author: ywangd

server/src/main/java/org/elasticsearch/cluster/InternalClusterInfoService.java

@@ -471,10 +471,8 @@ private void callListeners() {
         }
 
         private ClusterInfo updateAndGetCurrentClusterInfo() {
-            final IndicesStatsSummary indicesStatsSummary = this.indicesStatsSummary; // single volatile read
             final Map<String, EstimatedHeapUsage> estimatedHeapUsages = new HashMap<>();
-            final var currentMaxHeapPerNode = this.maxHeapPerNode; // Make sure we use a consistent view
-            currentMaxHeapPerNode.forEach((nodeId, maxHeapSize) -> {
+            maxHeapPerNode.forEach((nodeId, maxHeapSize) -> {
                 final Long estimatedHeapUsage = estimatedHeapUsagePerNode.get(nodeId);
                 if (estimatedHeapUsage != null) {
                     estimatedHeapUsages.put(nodeId, new EstimatedHeapUsage(nodeId, maxHeapSize.getBytes(), estimatedHeapUsage));
@@ -490,7 +488,7 @@ private ClusterInfo updateAndGetCurrentClusterInfo() {
                 estimatedHeapUsages,
                 nodeThreadPoolUsageStatsPerNode,
                 indicesStatsSummary.shardWriteLoads(),
-                currentMaxHeapPerNode
+                maxHeapPerNode
             );
             currentClusterInfo = newClusterInfo;
             return newClusterInfo;