Skip to content

Commit cc0de43

Browse files
author
Max Hniebergall
committed
Fix error in OpenAIUpgrade test which used the wrong field name for certain versions
1 parent 3d2d6a7 commit cc0de43

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

x-pack/plugin/inference/qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/xpack/application/OpenAiServiceUpgradeIT.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,9 @@ public void testOpenAiEmbeddings() throws IOException {
8585
assertEquals("openai", configs.get(0).get("service"));
8686
var serviceSettings = (Map<String, Object>) configs.get(0).get("service_settings");
8787
var taskSettings = (Map<String, Object>) configs.get(0).get("task_settings");
88-
var modelIdFound = serviceSettings.containsKey("model_id") || taskSettings.containsKey("model_id");
89-
assertTrue("model_id not found in config: " + configs.toString(), modelIdFound);
88+
var modelIdFound = serviceSettings.containsKey("model_id") || (taskSettings.containsKey("model") &&
89+
getOldClusterTestVersion().onOrBefore(OPEN_AI_EMBEDDINGS_MODEL_SETTING_MOVED));
90+
assertTrue("model_id not found in config: " + configs, modelIdFound);
9091

9192
assertEmbeddingInference(oldClusterId);
9293
} else if (isUpgradedCluster()) {

0 commit comments

Comments
 (0)