Skip to content

Commit cd54009

Browse files
committed
avoiding NPEs
1 parent b02c86e commit cd54009

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

modules/data-streams/src/main/java/org/elasticsearch/datastreams/action/PutDataStreamSettingsTransportAction.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,11 @@ private void updateSettingsOnIndices(
247247
// Called when all indices for all settings are complete
248248
@Override
249249
public void onResponse(Void unused) {
250-
DataStream dataStream = clusterService.state().projectState(projectResolver.getProjectId()).metadata().dataStreams().get(dataStreamName);
250+
DataStream dataStream = clusterService.state()
251+
.projectState(projectResolver.getProjectId())
252+
.metadata()
253+
.dataStreams()
254+
.get(dataStreamName);
251255
listener.onResponse(
252256
new PutDataStreamSettingsAction.DataStreamSettingsResponse(
253257
dataStreamName,

server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ public static ComposableIndexTemplate mergeSettingsIntoTemplate(ComposableIndexT
380380

381381
private static Settings mergeSettings(Settings originalSettings, Settings newSettings) {
382382
if (Settings.EMPTY.equals(newSettings)) {
383-
return originalSettings;
383+
return Objects.requireNonNullElse(originalSettings, Settings.EMPTY);
384384
}
385385
Settings.Builder settingsBuilder = Settings.builder().put(originalSettings).put(newSettings);
386386
for (String settingName : new HashSet<>(settingsBuilder.keys())) {

0 commit comments

Comments
 (0)