fix the other constructor

Author: not-napoleon

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/EsField.java

@@ -138,10 +138,6 @@ public EsField(
         this(name, esDataType, properties, aggregatable, false, timeSeriesFieldType);
     }
 
-    public EsField(String name, DataType esDataType, Map<String, EsField> properties, boolean aggregatable, boolean isAlias) {
-        this(name, esDataType, properties, aggregatable, isAlias, TimeSeriesFieldType.UNKNOWN);
-    }
-
     public EsField(
         String name,
         DataType esDataType,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java

@@ -464,7 +464,7 @@ private LocalRelation tableMapAsRelation(Source source, Map<String, Column> mapT
                 String name = entry.getKey();
                 Column column = entry.getValue();
                 // create a fake ES field - alternative is to use a ReferenceAttribute
-                EsField field = new EsField(name, column.type(), Map.of(), false, false);
+                EsField field = new EsField(name, column.type(), Map.of(), false, false, EsField.TimeSeriesFieldType.UNKNOWN);
                 attributes.add(new FieldAttribute(source, null, name, field));
                 // prepare the block for the supplier
                 blocks[i++] = column.values();

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/enrich/EnrichPolicyResolver.java

@@ -238,7 +238,8 @@ private Tuple<ResolvedEnrichPolicy, String> mergeLookupResults(
                     DataType.fromTypeName(field.getDataType().typeName()),
                     field.getProperties(),
                     field.isAggregatable(),
-                    field.isAlias()
+                    field.isAlias(),
+                    field.getTimeSeriesFieldType()
                 );
                 EsField old = mappings.putIfAbsent(m.getKey(), field);
                 if (old != null && old.getDataType().equals(field.getDataType()) == false) {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/enrich/ResolvedEnrichPolicy.java

@@ -54,7 +54,14 @@ public void writeTo(StreamOutput out) throws IOException {
              * as though it were the base class.
              */
             (o, v) -> {
-                var field = new EsField(v.getName(), v.getDataType(), v.getProperties(), v.isAggregatable(), v.isAlias());
+                var field = new EsField(
+                    v.getName(),
+                    v.getDataType(),
+                    v.getProperties(),
+                    v.isAggregatable(),
+                    v.isAlias(),
+                    v.getTimeSeriesFieldType()
+                );
                 if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_15_2)) {
                     field.writeTo(o);
                 } else {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/IndexResolver.java

@@ -234,7 +234,7 @@ private static EsField createField(
             return unsupported(name, first);
         }
 
-        return new EsField(name, type, new HashMap<>(), aggregatable, isAlias);
+        return new EsField(name, type, new HashMap<>(), aggregatable, isAlias, timeSeriesFieldType);
     }
 
     private static UnsupportedEsField unsupported(String name, IndexFieldCapabilities fc) {

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizerTests.java

@@ -498,7 +498,7 @@ public void testSparseDocument() throws Exception {
         Map<String, EsField> large = Maps.newLinkedHashMapWithExpectedSize(size);
         for (int i = 0; i < size; i++) {
             var name = String.format(Locale.ROOT, "field%03d", i);
-            large.put(name, new EsField(name, DataType.INTEGER, emptyMap(), true, false));
+            large.put(name, new EsField(name, DataType.INTEGER, emptyMap(), true, false, EsField.TimeSeriesFieldType.NONE));
         }
 
         SearchStats searchStats = statsForExistingField("field000", "field001", "field002", "field003", "field004");

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/type/EsFieldTests.java

@@ -19,7 +19,8 @@ public static EsField randomEsField(int maxPropertiesDepth) {
         Map<String, EsField> properties = randomProperties(maxPropertiesDepth);
         boolean aggregatable = randomBoolean();
         boolean isAlias = randomBoolean();
-        return new EsField(name, esDataType, properties, aggregatable, isAlias);
+        EsField.TimeSeriesFieldType tsType = randomFrom(EsField.TimeSeriesFieldType.values());
+        return new EsField(name, esDataType, properties, aggregatable, isAlias, tsType);
     }
 
     @Override
@@ -34,14 +35,16 @@ protected EsField mutate(EsField instance) {
         Map<String, EsField> properties = instance.getProperties();
         boolean aggregatable = instance.isAggregatable();
         boolean isAlias = instance.isAlias();
-        switch (between(0, 4)) {
+        EsField.TimeSeriesFieldType tsType = instance.getTimeSeriesFieldType();
+        switch (between(0, 5)) {
             case 0 -> name = randomAlphaOfLength(name.length() + 1);
             case 1 -> esDataType = randomValueOtherThan(esDataType, () -> randomFrom(DataType.types()));
             case 2 -> properties = randomValueOtherThan(properties, () -> randomProperties(4));
             case 3 -> aggregatable = false == aggregatable;
             case 4 -> isAlias = false == isAlias;
+            case 5 -> tsType = randomValueOtherThan(tsType, () -> randomFrom(EsField.TimeSeriesFieldType.values()));
             default -> throw new IllegalArgumentException();
         }
-        return new EsField(name, esDataType, properties, aggregatable, isAlias);
+        return new EsField(name, esDataType, properties, aggregatable, isAlias, tsType);
     }
 }