Remove test only MapperBuilderContext constructor (#109964)

MapperBuilderContext has a constructor that is only used in 3 places by tests. It is misleading in that
it sets hardcoded values for most of the arguments that are necessary to create a meaningful context object.
There's the risk that it gets called from production code, which we want to avoid, hence this commit removes
such constructor in favour of moving the constants to test code.

Author: javanna

server/src/main/java/org/elasticsearch/index/mapper/MapperBuilderContext.java

@@ -37,10 +37,6 @@ public static MapperBuilderContext root(boolean isSourceSynthetic, boolean isDat
     private final ObjectMapper.Dynamic dynamic;
     private final MergeReason mergeReason;
 
-    MapperBuilderContext(String path) {
-        this(path, false, false, false, ObjectMapper.Defaults.DYNAMIC, MergeReason.MAPPING_UPDATE);
-    }
-
     MapperBuilderContext(
         String path,
         boolean isSourceSynthetic,

server/src/test/java/org/elasticsearch/index/mapper/FieldAliasMapperValidationTests.java

@@ -159,7 +159,7 @@ public void testFieldAliasWithDifferentNestedScopes() {
 
     private static FieldMapper createFieldMapper(String parent, String name) {
         return new BooleanFieldMapper.Builder(name, ScriptCompiler.NONE, false, IndexVersion.current()).build(
-            new MapperBuilderContext(parent)
+            new MapperBuilderContext(parent, false, false, false, ObjectMapper.Defaults.DYNAMIC, MapperService.MergeReason.MAPPING_UPDATE)
         );
     }
 

server/src/test/java/org/elasticsearch/index/mapper/ObjectMapperMergeTests.java

@@ -332,7 +332,16 @@ private static RootObjectMapper createRootSubobjectFalseLeafWithDots() {
 
     private static ObjectMapper.Builder createObjectSubobjectsFalseLeafWithDots() {
         KeywordFieldMapper.Builder fieldBuilder = new KeywordFieldMapper.Builder("host.name", IndexVersion.current());
-        KeywordFieldMapper fieldMapper = fieldBuilder.build(new MapperBuilderContext("foo.metrics"));
+        KeywordFieldMapper fieldMapper = fieldBuilder.build(
+            new MapperBuilderContext(
+                "foo.metrics",
+                false,
+                false,
+                false,
+                ObjectMapper.Defaults.DYNAMIC,
+                MapperService.MergeReason.MAPPING_UPDATE
+            )
+        );
         assertEquals("host.name", fieldMapper.simpleName());
         assertEquals("foo.metrics.host.name", fieldMapper.name());
         return new ObjectMapper.Builder("foo", ObjectMapper.Defaults.SUBOBJECTS).add(
@@ -342,7 +351,16 @@ private static ObjectMapper.Builder createObjectSubobjectsFalseLeafWithDots() {
 
     private ObjectMapper.Builder createObjectSubobjectsFalseLeafWithMultiField() {
         TextFieldMapper.Builder fieldBuilder = createTextKeywordMultiField("host.name");
-        TextFieldMapper textKeywordMultiField = fieldBuilder.build(new MapperBuilderContext("foo.metrics"));
+        TextFieldMapper textKeywordMultiField = fieldBuilder.build(
+            new MapperBuilderContext(
+                "foo.metrics",
+                false,
+                false,
+                false,
+                ObjectMapper.Defaults.DYNAMIC,
+                MapperService.MergeReason.MAPPING_UPDATE
+            )
+        );
         assertEquals("host.name", textKeywordMultiField.simpleName());
         assertEquals("foo.metrics.host.name", textKeywordMultiField.name());
         FieldMapper fieldMapper = textKeywordMultiField.multiFields.iterator().next();