Skip to content

Commit d0a4a3f

Browse files
Test comments
1 parent 155c110 commit d0a4a3f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ public void testMergeTasksRunConcurrently() throws Exception {
264264
int totalMergeTasksCount = mergeExecutorThreadCount + randomIntBetween(1, 5);
265265
Semaphore runMergeSemaphore = new Semaphore(0);
266266
ThreadPoolExecutor threadPoolExecutor = (ThreadPoolExecutor) testThreadPool.executor(ThreadPool.Names.MERGE);
267+
// submit all merge tasks
267268
for (int i = 0; i < totalMergeTasksCount; i++) {
268269
MergeTask mergeTask = mock(MergeTask.class);
269270
when(mergeTask.supportsIOThrottling()).thenReturn(randomBoolean());
@@ -285,6 +286,7 @@ public void testMergeTasksRunConcurrently() throws Exception {
285286
}).when(mergeTask).run();
286287
threadPoolMergeExecutorService.submitMergeTask(mergeTask);
287288
}
289+
// assert stats while merge tasks finish
288290
for (int completedTasksCount = 0; completedTasksCount < totalMergeTasksCount
289291
- mergeExecutorThreadCount; completedTasksCount++) {
290292
int finalCompletedTasksCount = completedTasksCount;
@@ -306,7 +308,7 @@ public void testMergeTasksRunConcurrently() throws Exception {
306308
// let one merge task finish running
307309
runMergeSemaphore.release();
308310
}
309-
// merge tasks started drying out
311+
// there are now fewer merge tasks still running than available threads
310312
for (int remainingMergeTasksCount = mergeExecutorThreadCount; remainingMergeTasksCount >= 0; remainingMergeTasksCount--) {
311313
int finalRemainingMergeTasksCount = remainingMergeTasksCount;
312314
assertBusy(() -> {

0 commit comments

Comments
 (0)