Skip to content

Commit d207735

Browse files
nielsbaumanywangd
authored andcommitted
Mark temporary metadata builder methods as deprecated (MP-1968)
These methods will be removed at some point in the future. By marking them as deprecated, it'll be easier to spot that some code is using these methods. Additionally, this will hopefully prevent people from using these temporary methods.
1 parent f7e80e7 commit d207735

File tree

1 file changed

+32
-5
lines changed
  • server/src/main/java/org/elasticsearch/cluster/metadata

1 file changed

+32
-5
lines changed

server/src/main/java/org/elasticsearch/cluster/metadata/Metadata.java

Lines changed: 32 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,116 +1347,140 @@ public Builder forEachProject(UnaryOperator<ProjectMetadata.Builder> modifier) {
13471347
return this;
13481348
}
13491349

1350+
@Deprecated(forRemoval = true)
13501351
public Builder put(IndexMetadata.Builder indexMetadataBuilder) {
13511352
getSingleProject().put(indexMetadataBuilder);
13521353
return this;
13531354
}
13541355

1356+
@Deprecated(forRemoval = true)
13551357
public Builder put(IndexMetadata indexMetadata, boolean incrementVersion) {
13561358
getSingleProject().put(indexMetadata, incrementVersion);
13571359
return this;
13581360
}
13591361

1362+
@Deprecated(forRemoval = true)
13601363
public IndexMetadata get(String index) {
13611364
return getSingleProject().get(index);
13621365
}
13631366

1367+
@Deprecated(forRemoval = true)
13641368
public IndexMetadata getSafe(Index index) {
13651369
return getSingleProject().getSafe(index);
13661370
}
13671371

1372+
@Deprecated(forRemoval = true)
13681373
public Builder remove(String index) {
13691374
getSingleProject().remove(index);
13701375
return this;
13711376
}
13721377

1378+
@Deprecated(forRemoval = true)
13731379
public Builder removeAllIndices() {
13741380
getSingleProject().removeAllIndices();
13751381
return this;
13761382
}
13771383

1384+
@Deprecated(forRemoval = true)
13781385
public Builder indices(Map<String, IndexMetadata> indices) {
13791386
getSingleProject().indices(indices);
13801387
return this;
13811388
}
13821389

1390+
@Deprecated(forRemoval = true)
13831391
public Builder put(IndexTemplateMetadata.Builder template) {
13841392
getSingleProject().put(template);
13851393
return this;
13861394
}
13871395

1396+
@Deprecated(forRemoval = true)
13881397
public Builder put(IndexTemplateMetadata template) {
13891398
getSingleProject().put(template);
13901399
return this;
13911400
}
13921401

1402+
@Deprecated(forRemoval = true)
13931403
public Builder removeTemplate(String templateName) {
13941404
getSingleProject().removeTemplate(templateName);
13951405
return this;
13961406
}
13971407

1408+
@Deprecated(forRemoval = true)
13981409
public Builder templates(Map<String, IndexTemplateMetadata> templates) {
13991410
getSingleProject().templates(templates);
14001411
return this;
14011412
}
14021413

1414+
@Deprecated(forRemoval = true)
14031415
public Builder put(String name, ComponentTemplate componentTemplate) {
14041416
getSingleProject().put(name, componentTemplate);
14051417
return this;
14061418
}
14071419

1420+
@Deprecated(forRemoval = true)
14081421
public Builder removeComponentTemplate(String name) {
14091422
getSingleProject().removeComponentTemplate(name);
14101423
return this;
14111424
}
14121425

1426+
@Deprecated(forRemoval = true)
14131427
public Builder componentTemplates(Map<String, ComponentTemplate> componentTemplates) {
14141428
getSingleProject().componentTemplates(componentTemplates);
14151429
return this;
14161430
}
14171431

1432+
@Deprecated(forRemoval = true)
14181433
public Builder indexTemplates(Map<String, ComposableIndexTemplate> indexTemplates) {
14191434
getSingleProject().indexTemplates(indexTemplates);
14201435
return this;
14211436
}
14221437

1438+
@Deprecated(forRemoval = true)
14231439
public Builder put(String name, ComposableIndexTemplate indexTemplate) {
14241440
getSingleProject().put(name, indexTemplate);
14251441
return this;
14261442
}
14271443

1444+
@Deprecated(forRemoval = true)
14281445
public Builder removeIndexTemplate(String name) {
14291446
getSingleProject().removeIndexTemplate(name);
14301447
return this;
14311448
}
14321449

1450+
@Deprecated(forRemoval = true)
14331451
public DataStream dataStream(String dataStreamName) {
14341452
return getSingleProject().dataStream(dataStreamName);
14351453
}
14361454

1455+
@Deprecated(forRemoval = true)
14371456
public Builder dataStreams(Map<String, DataStream> dataStreams, Map<String, DataStreamAlias> dataStreamAliases) {
14381457
getSingleProject().dataStreams(dataStreams, dataStreamAliases);
14391458
return this;
14401459
}
14411460

1461+
@Deprecated(forRemoval = true)
14421462
public Builder put(DataStream dataStream) {
14431463
getSingleProject().put(dataStream);
14441464
return this;
14451465
}
14461466

1467+
@Deprecated(forRemoval = true)
14471468
public DataStreamMetadata dataStreamMetadata() {
14481469
return getSingleProject().dataStreamMetadata();
14491470
}
14501471

1472+
@Deprecated(forRemoval = true)
14511473
public boolean put(String aliasName, String dataStream, Boolean isWriteDataStream, String filter) {
14521474
return getSingleProject().put(aliasName, dataStream, isWriteDataStream, filter);
14531475
}
14541476

1477+
@Deprecated(forRemoval = true)
14551478
public Builder removeDataStream(String name) {
14561479
getSingleProject().removeDataStream(name);
14571480
return this;
14581481
}
14591482

1483+
@Deprecated(forRemoval = true)
14601484
public boolean removeDataStreamAlias(String aliasName, String dataStreamName, boolean mustExist) {
14611485
return getSingleProject().removeDataStreamAlias(aliasName, dataStreamName, mustExist);
14621486
}
@@ -1490,21 +1514,25 @@ public Builder customs(Map<String, ClusterCustom> clusterCustoms) {
14901514
return this;
14911515
}
14921516

1517+
@Deprecated(forRemoval = true)
14931518
public Builder putProjectCustom(String type, ProjectCustom custom) {
14941519
getSingleProject().putCustom(type, Objects.requireNonNull(custom, type));
14951520
return this;
14961521
}
14971522

1523+
@Deprecated(forRemoval = true)
14981524
public Builder removeProjectCustom(String type) {
14991525
getSingleProject().removeCustom(type);
15001526
return this;
15011527
}
15021528

1529+
@Deprecated(forRemoval = true)
15031530
public Builder removeProjectCustomIf(BiPredicate<String, ? super ProjectCustom> p) {
15041531
getSingleProject().removeCustomIf(p);
15051532
return this;
15061533
}
15071534

1535+
@Deprecated(forRemoval = true)
15081536
public Builder projectCustoms(Map<String, ProjectCustom> projectCustoms) {
15091537
projectCustoms.forEach((key, value) -> Objects.requireNonNull(value, key));
15101538
getSingleProject().customs(projectCustoms);
@@ -1541,20 +1569,18 @@ public Builder removeReservedState(ReservedStateMetadata metadata) {
15411569
return this;
15421570
}
15431571

1544-
public Builder putProjectReservedState(ReservedStateMetadata metadata) {
1545-
getSingleProject().put(metadata);
1546-
return this;
1547-
}
1548-
1572+
@Deprecated(forRemoval = true)
15491573
public Builder indexGraveyard(final IndexGraveyard indexGraveyard) {
15501574
getSingleProject().indexGraveyard(indexGraveyard);
15511575
return this;
15521576
}
15531577

1578+
@Deprecated(forRemoval = true)
15541579
public IndexGraveyard indexGraveyard() {
15551580
return getSingleProject().indexGraveyard();
15561581
}
15571582

1583+
@Deprecated(forRemoval = true)
15581584
public Builder updateSettings(Settings settings, String... indices) {
15591585
getSingleProject().updateSettings(settings, indices);
15601586
return this;
@@ -1567,6 +1593,7 @@ public Builder updateSettings(Settings settings, String... indices) {
15671593
* @param indices the indices to update the number of replicas for
15681594
* @return the builder
15691595
*/
1596+
@Deprecated(forRemoval = true)
15701597
public Builder updateNumberOfReplicas(final int numberOfReplicas, final String[] indices) {
15711598
getSingleProject().updateNumberOfReplicas(numberOfReplicas, indices);
15721599
return this;

0 commit comments

Comments
 (0)