Skip to content

Commit d2138e9

Browse files
committed
Fix some remaining references to simplified format
1 parent ff29ab8 commit d2138e9

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/rrf/RRFRetrieverBuilder.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@
4747
* formula.
4848
*/
4949
public final class RRFRetrieverBuilder extends CompoundRetrieverBuilder<RRFRetrieverBuilder> {
50-
public static final NodeFeature MULTI_FIELDS_QUERY_FORMAT_SUPPORT = new NodeFeature(
51-
"rrf_retriever.multi_fields_query_format_support"
52-
);
50+
public static final NodeFeature MULTI_FIELDS_QUERY_FORMAT_SUPPORT = new NodeFeature("rrf_retriever.multi_fields_query_format_support");
5351

5452
public static final String NAME = "rrf";
5553

x-pack/plugin/rank-rrf/src/test/java/org/elasticsearch/xpack/rank/rrf/RRFRetrieverBuilderTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public void testRetrieverExtractionErrors() throws IOException {
8484
}
8585
}
8686

87-
public void testSimplifiedParamsRewrite() {
87+
public void testMultiFieldsParamsRewrite() {
8888
final String indexName = "test-index";
8989
final List<String> testInferenceFields = List.of("semantic_field_1", "semantic_field_2");
9090
final ResolvedIndices resolvedIndices = createMockResolvedIndices(indexName, testInferenceFields, null);
@@ -105,7 +105,7 @@ public void testSimplifiedParamsRewrite() {
105105
DEFAULT_RANK_WINDOW_SIZE,
106106
RRFRetrieverBuilder.DEFAULT_RANK_CONSTANT
107107
);
108-
assertSimplifiedParamsRewrite(
108+
assertMultiFieldsParamsRewrite(
109109
rrfRetrieverBuilder,
110110
queryRewriteContext,
111111
Map.of("field_1", 1.0f, "field_2", 1.0f),
@@ -121,7 +121,7 @@ public void testSimplifiedParamsRewrite() {
121121
DEFAULT_RANK_WINDOW_SIZE * 2,
122122
RRFRetrieverBuilder.DEFAULT_RANK_CONSTANT / 2
123123
);
124-
assertSimplifiedParamsRewrite(
124+
assertMultiFieldsParamsRewrite(
125125
rrfRetrieverBuilder,
126126
queryRewriteContext,
127127
Map.of("field_1", 1.0f, "field_2", 1.0f),
@@ -137,7 +137,7 @@ public void testSimplifiedParamsRewrite() {
137137
DEFAULT_RANK_WINDOW_SIZE,
138138
RRFRetrieverBuilder.DEFAULT_RANK_CONSTANT
139139
);
140-
assertSimplifiedParamsRewrite(
140+
assertMultiFieldsParamsRewrite(
141141
rrfRetrieverBuilder,
142142
queryRewriteContext,
143143
Map.of("field_*", 1.0f, "*_field_1", 1.0f),
@@ -153,7 +153,7 @@ public void testSimplifiedParamsRewrite() {
153153
DEFAULT_RANK_WINDOW_SIZE,
154154
RRFRetrieverBuilder.DEFAULT_RANK_CONSTANT
155155
);
156-
assertSimplifiedParamsRewrite(
156+
assertMultiFieldsParamsRewrite(
157157
rrfRetrieverBuilder,
158158
queryRewriteContext,
159159
Map.of("*", 1.0f),
@@ -248,7 +248,7 @@ private static ResolvedIndices createMockResolvedIndices(
248248
);
249249
}
250250

251-
private static void assertSimplifiedParamsRewrite(
251+
private static void assertMultiFieldsParamsRewrite(
252252
RRFRetrieverBuilder retriever,
253253
QueryRewriteContext ctx,
254254
Map<String, Float> expectedNonInferenceFields,

0 commit comments

Comments
 (0)