Skip to content

Commit d2c3c03

Browse files
committed
Fix tests
1 parent 0ba789f commit d2c3c03

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestRerankingServiceExtension.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@
4949

5050
public class TestRerankingServiceExtension implements InferenceServiceExtension {
5151

52+
public static final int RERANK_WINDOW_SIZE = 333;
53+
5254
@Override
5355
public List<Factory> getInferenceServiceFactories() {
5456
return List.of(TestInferenceService::new);
@@ -203,7 +205,7 @@ protected ServiceSettings getServiceSettingsFromMap(Map<String, Object> serviceS
203205

204206
@Override
205207
public int rerankerWindowSize(String modelId) {
206-
return 333;
208+
return RERANK_WINDOW_SIZE;
207209
}
208210

209211
public static class Configuration {

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/integration/RerankWindowSizeIT.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.elasticsearch.xpack.inference.LocalStateInferencePlugin;
1616
import org.elasticsearch.xpack.inference.Utils;
1717
import org.elasticsearch.xpack.inference.mock.TestInferenceServicePlugin;
18+
import org.elasticsearch.xpack.inference.mock.TestRerankingServiceExtension;
1819
import org.elasticsearch.xpack.inference.registry.ModelRegistry;
1920
import org.junit.Before;
2021

@@ -41,7 +42,7 @@ protected Collection<Class<? extends Plugin>> nodePlugins() {
4142
public void testRerankWindowSizeAction() {
4243
var response = client().execute(GetRerankerWindowSizeAction.INSTANCE, new GetRerankerWindowSizeAction.Request("rerank-endpoint"))
4344
.actionGet();
44-
assertEquals(333, response.getWindowSize());
45+
assertEquals(TestRerankingServiceExtension.RERANK_WINDOW_SIZE, response.getWindowSize());
4546
}
4647

4748
public void testActionNotAReranker() {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/ai21/Ai21ServiceTests.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import org.elasticsearch.common.xcontent.XContentHelper;
2020
import org.elasticsearch.core.TimeValue;
2121
import org.elasticsearch.inference.EmptyTaskSettings;
22+
import org.elasticsearch.inference.InferenceService;
2223
import org.elasticsearch.inference.InferenceServiceConfiguration;
2324
import org.elasticsearch.inference.InferenceServiceResults;
2425
import org.elasticsearch.inference.InputType;
@@ -562,4 +563,8 @@ private Map<String, Object> getRequestConfigMap(Map<String, Object> serviceSetti
562563
return new HashMap<>(Map.of(ModelConfigurations.SERVICE_SETTINGS, builtServiceSettings));
563564
}
564565

566+
@Override
567+
public InferenceService createInferenceService() {
568+
return createService();
569+
}
565570
}

0 commit comments

Comments
 (0)