Skip to content

Commit d30b2a5

Browse files
TODOs
1 parent 26d1b94 commit d30b2a5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

server/src/main/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncAction.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ public static void registerNodeSearchAction(SearchTransportService searchTranspo
793793
((CancellableTask) task)::isCancelled,
794794
SearchProgressListener.NOOP,
795795
shardCount,
796-
Integer.MAX_VALUE,
796+
Integer.MAX_VALUE, // TODO: intermediary reduces
797797
e -> logger.error("failed to merge on data node", e)
798798
),
799799
request,
@@ -875,6 +875,7 @@ private void setFailure(QueryPerNodeState state, int dataNodeLocalIdx, Exception
875875
@Override
876876
public void onFailure(Exception e) {
877877
try {
878+
// TODO: count down fully and just respond with an exception if partial results aren't allowed
878879
setFailure(state, dataNodeLocalIdx, e);
879880
maybeNext();
880881
} catch (Throwable expected) {

0 commit comments

Comments
 (0)