Adding test for highlighting

Author: Samiul-TheSoccerFan

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/integration/SemanticTextIndexVersionIT.java

@@ -7,12 +7,13 @@
 
 package org.elasticsearch.xpack.inference.integration;
 
-import org.elasticsearch.action.DocWriteResponse;;
+import org.elasticsearch.action.DocWriteResponse;
 import org.elasticsearch.action.admin.indices.refresh.RefreshRequest;
 import org.elasticsearch.action.search.SearchRequest;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.index.IndexVersion;
+import org.elasticsearch.index.mapper.InferenceMetadataFieldsMapper;
 import org.elasticsearch.license.LicenseSettings;
 import org.elasticsearch.plugins.Plugin;
 import org.elasticsearch.search.builder.SearchSourceBuilder;
@@ -45,7 +46,7 @@ public class SemanticTextIndexVersionIT extends ESIntegTestCase {
     private static final IndexVersion SEMANTIC_TEXT_INTRODUCED_VERSION = IndexVersion.fromId(8512000);
 
     private Set<IndexVersion> availableVersions;
-    private static final int MIN_NUMBER_OF_TESTS_TO_RUN = 1;
+    private static final int MIN_NUMBER_OF_TESTS_TO_RUN = 10;
 
     @Before
     public void setup() throws Exception {
@@ -154,16 +155,25 @@ public void testSemanticText() throws Exception {
                 assertHitCount(response, 1L);
             });
 
-            //Semantic Search with highlighter
-            SearchSourceBuilder sourceHighlighterBuilder = new SearchSourceBuilder()
-                .query(new SemanticQueryBuilder("semantic_field", "inference"))
-                .highlighter(new HighlightBuilder().field(new HighlightBuilder.Field("semantic_field").numOfFragments(1)))
-                .trackTotalHits(true);
-
-            assertResponse(client().search(new SearchRequest(indexName).source(sourceBuilder)), response -> {
-                assertHitCount(response, 1L);
-                assertHighlight(response, 0, "semantic_field", 0, 2, equalTo("inference"));
-            });
+            //Semantic Search with highlighter only available from 8.18 and 9.0
+            Settings settings = client().admin()
+                .indices()
+                .prepareGetSettings(TimeValue.THIRTY_SECONDS, indexName)
+                .get()
+                .getIndexToSettings()
+                .get(indexName);
+
+            if (InferenceMetadataFieldsMapper.isEnabled(settings)) {
+                SearchSourceBuilder sourceHighlighterBuilder = new SearchSourceBuilder()
+                    .query(new SemanticQueryBuilder("semantic_field", "inference"))
+                    .highlighter(new HighlightBuilder().field("semantic_field"))
+                    .trackTotalHits(true);
+
+                assertResponse(client().search(new SearchRequest(indexName).source(sourceHighlighterBuilder)), response -> {
+                    assertHighlight(response, 0, "semantic_field", 0, 2, equalTo("inference test"));
+                    assertHighlight(response, 0, "semantic_field", 1, 2, equalTo("another inference test"));
+                });
+            }
         }
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/LocalStateInferencePlugin.java

@@ -15,10 +15,12 @@
 import org.elasticsearch.inference.InferenceServiceExtension;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.plugins.SearchPlugin;
+import org.elasticsearch.search.fetch.subphase.highlight.Highlighter;
 import org.elasticsearch.xpack.core.LocalStateCompositeXPackPlugin;
 import org.elasticsearch.xpack.core.ml.inference.MlInferenceNamedXContentProvider;
 import org.elasticsearch.xpack.core.ml.search.SparseVectorQueryBuilder;
 import org.elasticsearch.xpack.core.ssl.SSLService;
+import org.elasticsearch.xpack.inference.highlight.SemanticTextHighlighter;
 import org.elasticsearch.xpack.inference.mock.TestDenseInferenceServiceExtension;
 import org.elasticsearch.xpack.inference.mock.TestSparseInferenceServiceExtension;
 
@@ -68,6 +70,11 @@ public Map<String, Mapper.TypeParser> getMappers() {
         return inferencePlugin.getMappers();
     }
 
+    @Override
+    public Map<String, Highlighter> getHighlighters() {
+        return Map.of(SemanticTextHighlighter.NAME, new SemanticTextHighlighter());
+    }
+
     @Override
     public Collection<MappedActionFilter> getMappedActionFilters() {
         return inferencePlugin.getMappedActionFilters();