Don't ignore IOExceptions in temp file cleanup

jordan-powers · jordan-powers · commit d61633b805d8 · 2025-04-17T10:17:25.000-07:00
diff --git a/server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesConsumer.java b/server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesConsumer.java
@@ -600,11 +600,7 @@ public void accept(int docValueCount) throws IOException {
                     }
                 } finally {
                     if (addressDataOutputName != null) {
-                        try {
-                            dir.deleteFile(addressDataOutputName);
-                        } catch (final IOException ignored) {
-                            // ignore exception
-                        }
+                        dir.deleteFile(addressDataOutputName);
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -600,11 +600,7 @@ public void accept(int docValueCount) throws IOException {`
`600`	`600`	`}`
`601`	`601`	`} finally {`
`602`	`602`	`if (addressDataOutputName != null) {`
`603`		`- try {`
`604`		`- dir.deleteFile(addressDataOutputName);`
`605`		`- } catch (final IOException ignored) {`
`606`		`- // ignore exception`
`607`		`- }`
	`603`	`+ dir.deleteFile(addressDataOutputName);`
`608`	`604`	`}`
`609`	`605`	`}`
`610`	`606`	`}`