Fix failing LuceneFilesExtensionsTests testIsLuceneExtension case (#135069)

This fixes a small randomization issue leading to occasional AOOB in
this test.

Closes #134970

Author: cbuescher

muted-tests.yml

@@ -558,9 +558,6 @@ tests:
 - class: org.elasticsearch.action.search.BatchedQueryPhaseIT
   method: testNumReducePhases
   issue: https://github.com/elastic/elasticsearch/issues/134943
-- class: org.elasticsearch.index.store.LuceneFilesExtensionsTests
-  method: testIsLuceneExtension
-  issue: https://github.com/elastic/elasticsearch/issues/134970
 - class: org.elasticsearch.reservedstate.service.RepositoriesFileSettingsIT
   method: testSettingsApplied
   issue: https://github.com/elastic/elasticsearch/issues/126748

qa/evil-tests/src/test/java/org/elasticsearch/index/store/LuceneFilesExtensionsTests.java

@@ -51,7 +51,7 @@ public void testIsLuceneExtension() {
         assertFalse(LuceneFilesExtensions.isLuceneExtension("bcde"));
         String randomStringWithLuceneExtension = randomAlphanumericOfLength(10)
             + "."
-            + LuceneFilesExtensions.values()[randomInt(LuceneFilesExtensions.values().length) - 1].getExtension();
+            + LuceneFilesExtensions.values()[randomInt(LuceneFilesExtensions.values().length - 1)].getExtension();
         String extension = IndexFileNames.getExtension(randomStringWithLuceneExtension);
         assertTrue(extension + " should be considered a Lucene extension", LuceneFilesExtensions.isLuceneExtension(extension));
         String upperCaseExtension = extension.toUpperCase(Locale.ROOT);